Mixing
![Change jobs to earn more, or stay the same to gain experience? [closed]](https://blogger.googleusercontent.com/img/b/R29vZ2xl/AVvXsEgjbpfN9tAutmK93bJRC3ZoROZzi2TJDms5n8_qJuhgE0a9b52OOHayv3NGT8igAdFL7byXNst-_1DZK5SjrIJ28_6RQPUpBROqMs5s6jo-ZsjX8kjDwfxJufIitH3TaQRXWaGSQKRQib-f/s72-c/1.jpg)
Co-worker letting coding standards drop again after large refactor - how to enforce better practices? [on hold]
Clash Royale CLAN TAG#URR8PPP
.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty margin-bottom:0;
up vote
0
down vote
favorite
After we spent 4 years cleaning up the code and it is working OK again, my colleague started to get messy again. Ignoring Reviews with the usual phrase "I have more important tasks to do atm" means that reviews are only for show. An unused variable, so what? Copy/Paste, perfectly OK practice!
I'm responsible for code reviews in the team and while his code works it is messy and I fear we may be throwing away the last 4 years of cleanup efforts and ending up right back where we started.
How can I get this coworker to understand the importance of what I am trying to enforce or at the very least how can I ensure compliance?
coworker code
edited 1 min ago
motosubatsu
32.7k1583132
asked 23 hours ago
Sangoku
1101
New contributor
Sangoku is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
put on hold as off-topic by gnat, Rory Alsop, Twyxz, Mister Positive, Jenny D 12 mins ago
This question appears to be off-topic. The users who voted to close gave this specific reason:
- "Questions require a goal that we can address. Rather than explaining the difficulties of your situation, explain what you want to do to make it better. For more information, see this meta post." – gnat, Rory Alsop, Twyxz, Mister Positive, Jenny D
add a comment |Â
up vote
0
down vote
favorite
After we spent 4 years cleaning up the code and it is working OK again, my colleague started to get messy again. Ignoring Reviews with the usual phrase "I have more important tasks to do atm" means that reviews are only for show. An unused variable, so what? Copy/Paste, perfectly OK practice!
I'm responsible for code reviews in the team and while his code works it is messy and I fear we may be throwing away the last 4 years of cleanup efforts and ending up right back where we started.
How can I get this coworker to understand the importance of what I am trying to enforce or at the very least how can I ensure compliance?
coworker code
edited 1 min ago
motosubatsu
32.7k1583132
asked 23 hours ago
Sangoku
1101
New contributor
Sangoku is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
put on hold as off-topic by gnat, Rory Alsop, Twyxz, Mister Positive, Jenny D 12 mins ago
This question appears to be off-topic. The users who voted to close gave this specific reason:
- "Questions require a goal that we can address. Rather than explaining the difficulties of your situation, explain what you want to do to make it better. For more information, see this meta post." – gnat, Rory Alsop, Twyxz, Mister Positive, Jenny D
7
Who manages the adherence to your standards (i.e. if somebody is not keeping to the standard - who is responsible for getting them back on track)? And are you peers, or is this colleague junior to you (inc. are you their manager)? Also, are these standards well-defined and enforced, or are they just general "good practices" your department has informally tried to keep until now?
– Bilkokuya
22 hours ago
How do you want this to work out? Are you wanting this guy to conform to coding standards? Does the messy code keep breaking the builds and prevent you from working? How does everyone else feel about this?
– Snow♦
22 hours ago
I am responsible for code rewievs... BUT he just ignores the dev process and commits on Master or merges it self... And im tired of playing cop after 2 years because of unwilingness to change. His point of view is that the code is already Garbage so what change does my garbage make?
– Sangoku
5 hours ago
add a comment |Â
up vote
0
down vote
favorite
up vote
0
down vote
favorite
After we spent 4 years cleaning up the code and it is working OK again, my colleague started to get messy again. Ignoring Reviews with the usual phrase "I have more important tasks to do atm" means that reviews are only for show. An unused variable, so what? Copy/Paste, perfectly OK practice!
I'm responsible for code reviews in the team and while his code works it is messy and I fear we may be throwing away the last 4 years of cleanup efforts and ending up right back where we started.
How can I get this coworker to understand the importance of what I am trying to enforce or at the very least how can I ensure compliance?
coworker code
edited 1 min ago
motosubatsu
32.7k1583132
asked 23 hours ago
Sangoku
1101
New contributor
Sangoku is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
After we spent 4 years cleaning up the code and it is working OK again, my colleague started to get messy again. Ignoring Reviews with the usual phrase "I have more important tasks to do atm" means that reviews are only for show. An unused variable, so what? Copy/Paste, perfectly OK practice!
I'm responsible for code reviews in the team and while his code works it is messy and I fear we may be throwing away the last 4 years of cleanup efforts and ending up right back where we started.
How can I get this coworker to understand the importance of what I am trying to enforce or at the very least how can I ensure compliance?
coworker code
coworker code
edited 1 min ago
motosubatsu
32.7k1583132
asked 23 hours ago
Sangoku
1101
New contributor
Sangoku is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited 1 min ago
motosubatsu
32.7k1583132
asked 23 hours ago
Sangoku
1101
New contributor
Sangoku is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited 1 min ago
motosubatsu
32.7k1583132
edited 1 min ago
motosubatsu
32.7k1583132
edited 1 min ago
motosubatsu
32.7k1583132
32.7k1583132
asked 23 hours ago
Sangoku
1101
New contributor
Sangoku is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 23 hours ago
Sangoku
1101
asked 23 hours ago
Sangoku
1101
1101
New contributor
Sangoku is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
Sangoku is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Sangoku is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
put on hold as off-topic by gnat, Rory Alsop, Twyxz, Mister Positive, Jenny D 12 mins ago
This question appears to be off-topic. The users who voted to close gave this specific reason:
- "Questions require a goal that we can address. Rather than explaining the difficulties of your situation, explain what you want to do to make it better. For more information, see this meta post." – gnat, Rory Alsop, Twyxz, Mister Positive, Jenny D
put on hold as off-topic by gnat, Rory Alsop, Twyxz, Mister Positive, Jenny D 12 mins ago
This question appears to be off-topic. The users who voted to close gave this specific reason:
- "Questions require a goal that we can address. Rather than explaining the difficulties of your situation, explain what you want to do to make it better. For more information, see this meta post." – gnat, Rory Alsop, Twyxz, Mister Positive, Jenny D
7
Who manages the adherence to your standards (i.e. if somebody is not keeping to the standard - who is responsible for getting them back on track)? And are you peers, or is this colleague junior to you (inc. are you their manager)? Also, are these standards well-defined and enforced, or are they just general "good practices" your department has informally tried to keep until now?
– Bilkokuya
22 hours ago
How do you want this to work out? Are you wanting this guy to conform to coding standards? Does the messy code keep breaking the builds and prevent you from working? How does everyone else feel about this?
– Snow♦
22 hours ago
I am responsible for code rewievs... BUT he just ignores the dev process and commits on Master or merges it self... And im tired of playing cop after 2 years because of unwilingness to change. His point of view is that the code is already Garbage so what change does my garbage make?
– Sangoku
5 hours ago
add a comment |Â
7
Who manages the adherence to your standards (i.e. if somebody is not keeping to the standard - who is responsible for getting them back on track)? And are you peers, or is this colleague junior to you (inc. are you their manager)? Also, are these standards well-defined and enforced, or are they just general "good practices" your department has informally tried to keep until now?
– Bilkokuya
22 hours ago
How do you want this to work out? Are you wanting this guy to conform to coding standards? Does the messy code keep breaking the builds and prevent you from working? How does everyone else feel about this?
– Snow♦
22 hours ago
I am responsible for code rewievs... BUT he just ignores the dev process and commits on Master or merges it self... And im tired of playing cop after 2 years because of unwilingness to change. His point of view is that the code is already Garbage so what change does my garbage make?
– Sangoku
5 hours ago
7
7
Who manages the adherence to your standards (i.e. if somebody is not keeping to the standard - who is responsible for getting them back on track)? And are you peers, or is this colleague junior to you (inc. are you their manager)? Also, are these standards well-defined and enforced, or are they just general "good practices" your department has informally tried to keep until now?
– Bilkokuya
22 hours ago
Who manages the adherence to your standards (i.e. if somebody is not keeping to the standard - who is responsible for getting them back on track)? And are you peers, or is this colleague junior to you (inc. are you their manager)? Also, are these standards well-defined and enforced, or are they just general "good practices" your department has informally tried to keep until now?
– Bilkokuya
22 hours ago
How do you want this to work out? Are you wanting this guy to conform to coding standards? Does the messy code keep breaking the builds and prevent you from working? How does everyone else feel about this?
– Snow♦
22 hours ago
How do you want this to work out? Are you wanting this guy to conform to coding standards? Does the messy code keep breaking the builds and prevent you from working? How does everyone else feel about this?
– Snow♦
22 hours ago
I am responsible for code rewievs... BUT he just ignores the dev process and commits on Master or merges it self... And im tired of playing cop after 2 years because of unwilingness to change. His point of view is that the code is already Garbage so what change does my garbage make?
– Sangoku
5 hours ago
I am responsible for code rewievs... BUT he just ignores the dev process and commits on Master or merges it self... And im tired of playing cop after 2 years because of unwilingness to change. His point of view is that the code is already Garbage so what change does my garbage make?
– Sangoku
5 hours ago
add a comment |Â
3 Answers
3
active
oldest
votes
up vote
4
down vote
Depends on how much authority you have in the company. In general, the way the code review process is supposed to work is that the code reviewer is supposed to be a "gatekeeper"; if the review isn't approved then the code doesn't get pushed to production. Even if you are a lower job title than your coworker, as the reviewer, you (are supposed to) have the power. If he says "no that's dumb I'm not going to fix my code", then say back to him "no, THAT'S dumb, I'm just going to block all your pull requests until you do what I say" (obviously not in those words, you can be more diplomatic about it, but that's the point to get across).
That said, it's possible that this coworker will just stop sending you code reviews and start sending them to someone he sees as less "nitpicky", as it were. In which case it's your job to make sure everyone on your team is as nitpicky as you are, and you should treat that as a challenge. Presumably, after 4 years of refactoring, nobody wants to do that again; explain to your boss and to your coworkers that in order to make sure that this doesn't happen again, there need to be tight code standards and everyone, including this other coworker, needs to follow them. Then, make it your boss's problem, and present it to him this way (again, diplomatically): Either he can back you up and make your coworker write good code, or he can spend another 4 years refactoring. He'll know the right choice to make.
answered 22 hours ago
Ertai87
3,086212
add a comment |Â
up vote
1
down vote
What can I do?
Stop stressing this so much, and focus on your tasks and code.
It does stink I will admit, but it is not something you can control. I would however suggest you speak to your manager about it as overtime the cost down the road can be great. Be prepared to show examples to back up your claims.
Also be prepared for your co-worker to no longer be as friendly towards you.
answered 55 mins ago
Mister Positive
58.1k30191236
add a comment |Â
up vote
0
down vote
Messy, unreadable code is a form of technical debt that only gets worse with time. You can do style linting and put in hard blocks to prevent code that fails linting from getting merged. But given you've already talked to your colleague and he is ignoring code reviews, the situation seems better handled by the tech lead or engineering manager.
answered 20 hours ago
jcmack
5,0551931
I will just forward my problem to the Manager, we are a small group of 4 developers. There is no seniority, im longer here but because im lacking in the native language he is the lead on paper. But i do the design choices.... that is where the conflict arose...
– Sangoku
5 hours ago
add a comment |Â
3 Answers
3
active
oldest
votes
3 Answers
3
active
oldest
votes
active
oldest
votes
active
oldest
votes
up vote
4
down vote
Depends on how much authority you have in the company. In general, the way the code review process is supposed to work is that the code reviewer is supposed to be a "gatekeeper"; if the review isn't approved then the code doesn't get pushed to production. Even if you are a lower job title than your coworker, as the reviewer, you (are supposed to) have the power. If he says "no that's dumb I'm not going to fix my code", then say back to him "no, THAT'S dumb, I'm just going to block all your pull requests until you do what I say" (obviously not in those words, you can be more diplomatic about it, but that's the point to get across).
That said, it's possible that this coworker will just stop sending you code reviews and start sending them to someone he sees as less "nitpicky", as it were. In which case it's your job to make sure everyone on your team is as nitpicky as you are, and you should treat that as a challenge. Presumably, after 4 years of refactoring, nobody wants to do that again; explain to your boss and to your coworkers that in order to make sure that this doesn't happen again, there need to be tight code standards and everyone, including this other coworker, needs to follow them. Then, make it your boss's problem, and present it to him this way (again, diplomatically): Either he can back you up and make your coworker write good code, or he can spend another 4 years refactoring. He'll know the right choice to make.
answered 22 hours ago
Ertai87
3,086212
add a comment |Â
up vote
4
down vote
Depends on how much authority you have in the company. In general, the way the code review process is supposed to work is that the code reviewer is supposed to be a "gatekeeper"; if the review isn't approved then the code doesn't get pushed to production. Even if you are a lower job title than your coworker, as the reviewer, you (are supposed to) have the power. If he says "no that's dumb I'm not going to fix my code", then say back to him "no, THAT'S dumb, I'm just going to block all your pull requests until you do what I say" (obviously not in those words, you can be more diplomatic about it, but that's the point to get across).
That said, it's possible that this coworker will just stop sending you code reviews and start sending them to someone he sees as less "nitpicky", as it were. In which case it's your job to make sure everyone on your team is as nitpicky as you are, and you should treat that as a challenge. Presumably, after 4 years of refactoring, nobody wants to do that again; explain to your boss and to your coworkers that in order to make sure that this doesn't happen again, there need to be tight code standards and everyone, including this other coworker, needs to follow them. Then, make it your boss's problem, and present it to him this way (again, diplomatically): Either he can back you up and make your coworker write good code, or he can spend another 4 years refactoring. He'll know the right choice to make.
answered 22 hours ago
Ertai87
3,086212
add a comment |Â
up vote
4
down vote
up vote
4
down vote
Depends on how much authority you have in the company. In general, the way the code review process is supposed to work is that the code reviewer is supposed to be a "gatekeeper"; if the review isn't approved then the code doesn't get pushed to production. Even if you are a lower job title than your coworker, as the reviewer, you (are supposed to) have the power. If he says "no that's dumb I'm not going to fix my code", then say back to him "no, THAT'S dumb, I'm just going to block all your pull requests until you do what I say" (obviously not in those words, you can be more diplomatic about it, but that's the point to get across).
That said, it's possible that this coworker will just stop sending you code reviews and start sending them to someone he sees as less "nitpicky", as it were. In which case it's your job to make sure everyone on your team is as nitpicky as you are, and you should treat that as a challenge. Presumably, after 4 years of refactoring, nobody wants to do that again; explain to your boss and to your coworkers that in order to make sure that this doesn't happen again, there need to be tight code standards and everyone, including this other coworker, needs to follow them. Then, make it your boss's problem, and present it to him this way (again, diplomatically): Either he can back you up and make your coworker write good code, or he can spend another 4 years refactoring. He'll know the right choice to make.
answered 22 hours ago
Ertai87
3,086212
Depends on how much authority you have in the company. In general, the way the code review process is supposed to work is that the code reviewer is supposed to be a "gatekeeper"; if the review isn't approved then the code doesn't get pushed to production. Even if you are a lower job title than your coworker, as the reviewer, you (are supposed to) have the power. If he says "no that's dumb I'm not going to fix my code", then say back to him "no, THAT'S dumb, I'm just going to block all your pull requests until you do what I say" (obviously not in those words, you can be more diplomatic about it, but that's the point to get across).
That said, it's possible that this coworker will just stop sending you code reviews and start sending them to someone he sees as less "nitpicky", as it were. In which case it's your job to make sure everyone on your team is as nitpicky as you are, and you should treat that as a challenge. Presumably, after 4 years of refactoring, nobody wants to do that again; explain to your boss and to your coworkers that in order to make sure that this doesn't happen again, there need to be tight code standards and everyone, including this other coworker, needs to follow them. Then, make it your boss's problem, and present it to him this way (again, diplomatically): Either he can back you up and make your coworker write good code, or he can spend another 4 years refactoring. He'll know the right choice to make.
answered 22 hours ago
Ertai87
3,086212
answered 22 hours ago
Ertai87
3,086212
answered 22 hours ago
Ertai87
3,086212
answered 22 hours ago
Ertai87
3,086212
3,086212
add a comment |Â
add a comment |Â
up vote
1
down vote
What can I do?
Stop stressing this so much, and focus on your tasks and code.
It does stink I will admit, but it is not something you can control. I would however suggest you speak to your manager about it as overtime the cost down the road can be great. Be prepared to show examples to back up your claims.
Also be prepared for your co-worker to no longer be as friendly towards you.
answered 55 mins ago
Mister Positive
58.1k30191236
add a comment |Â
up vote
1
down vote
What can I do?
Stop stressing this so much, and focus on your tasks and code.
It does stink I will admit, but it is not something you can control. I would however suggest you speak to your manager about it as overtime the cost down the road can be great. Be prepared to show examples to back up your claims.
Also be prepared for your co-worker to no longer be as friendly towards you.
answered 55 mins ago
Mister Positive
58.1k30191236
add a comment |Â
up vote
1
down vote
up vote
1
down vote
What can I do?
Stop stressing this so much, and focus on your tasks and code.
It does stink I will admit, but it is not something you can control. I would however suggest you speak to your manager about it as overtime the cost down the road can be great. Be prepared to show examples to back up your claims.
Also be prepared for your co-worker to no longer be as friendly towards you.
answered 55 mins ago
Mister Positive
58.1k30191236
What can I do?
Stop stressing this so much, and focus on your tasks and code.
It does stink I will admit, but it is not something you can control. I would however suggest you speak to your manager about it as overtime the cost down the road can be great. Be prepared to show examples to back up your claims.
Also be prepared for your co-worker to no longer be as friendly towards you.
answered 55 mins ago
Mister Positive
58.1k30191236
answered 55 mins ago
Mister Positive
58.1k30191236
answered 55 mins ago
Mister Positive
58.1k30191236
answered 55 mins ago
Mister Positive
58.1k30191236
58.1k30191236
add a comment |Â
add a comment |Â
up vote
0
down vote
Messy, unreadable code is a form of technical debt that only gets worse with time. You can do style linting and put in hard blocks to prevent code that fails linting from getting merged. But given you've already talked to your colleague and he is ignoring code reviews, the situation seems better handled by the tech lead or engineering manager.
answered 20 hours ago
jcmack
5,0551931
I will just forward my problem to the Manager, we are a small group of 4 developers. There is no seniority, im longer here but because im lacking in the native language he is the lead on paper. But i do the design choices.... that is where the conflict arose...
– Sangoku
5 hours ago
add a comment |Â
up vote
0
down vote
Messy, unreadable code is a form of technical debt that only gets worse with time. You can do style linting and put in hard blocks to prevent code that fails linting from getting merged. But given you've already talked to your colleague and he is ignoring code reviews, the situation seems better handled by the tech lead or engineering manager.
answered 20 hours ago
jcmack
5,0551931
I will just forward my problem to the Manager, we are a small group of 4 developers. There is no seniority, im longer here but because im lacking in the native language he is the lead on paper. But i do the design choices.... that is where the conflict arose...
– Sangoku
5 hours ago
add a comment |Â
up vote
0
down vote
up vote
0
down vote
Messy, unreadable code is a form of technical debt that only gets worse with time. You can do style linting and put in hard blocks to prevent code that fails linting from getting merged. But given you've already talked to your colleague and he is ignoring code reviews, the situation seems better handled by the tech lead or engineering manager.
answered 20 hours ago
jcmack
5,0551931
Messy, unreadable code is a form of technical debt that only gets worse with time. You can do style linting and put in hard blocks to prevent code that fails linting from getting merged. But given you've already talked to your colleague and he is ignoring code reviews, the situation seems better handled by the tech lead or engineering manager.
answered 20 hours ago
jcmack
5,0551931
answered 20 hours ago
jcmack
5,0551931
answered 20 hours ago
jcmack
5,0551931
answered 20 hours ago
jcmack
5,0551931
5,0551931
I will just forward my problem to the Manager, we are a small group of 4 developers. There is no seniority, im longer here but because im lacking in the native language he is the lead on paper. But i do the design choices.... that is where the conflict arose...
– Sangoku
5 hours ago
add a comment |Â
I will just forward my problem to the Manager, we are a small group of 4 developers. There is no seniority, im longer here but because im lacking in the native language he is the lead on paper. But i do the design choices.... that is where the conflict arose...
– Sangoku
5 hours ago
I will just forward my problem to the Manager, we are a small group of 4 developers. There is no seniority, im longer here but because im lacking in the native language he is the lead on paper. But i do the design choices.... that is where the conflict arose...
– Sangoku
5 hours ago
I will just forward my problem to the Manager, we are a small group of 4 developers. There is no seniority, im longer here but because im lacking in the native language he is the lead on paper. But i do the design choices.... that is where the conflict arose...
– Sangoku
5 hours ago
add a comment |Â
7
Who manages the adherence to your standards (i.e. if somebody is not keeping to the standard - who is responsible for getting them back on track)? And are you peers, or is this colleague junior to you (inc. are you their manager)? Also, are these standards well-defined and enforced, or are they just general "good practices" your department has informally tried to keep until now?
– Bilkokuya
22 hours ago
How do you want this to work out? Are you wanting this guy to conform to coding standards? Does the messy code keep breaking the builds and prevent you from working? How does everyone else feel about this?
– Snow♦
22 hours ago
I am responsible for code rewievs... BUT he just ignores the dev process and commits on Master or merges it self... And im tired of playing cop after 2 years because of unwilingness to change. His point of view is that the code is already Garbage so what change does my garbage make?
– Sangoku
5 hours ago