Mixing
Code reviewing hostile developer
Clash Royale CLAN TAG#URR8PPP
.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty margin-bottom:0;
up vote
1
down vote
favorite
I am in the following situation. Small team witin a large unit with many teams. There is officiel code review process,but to a lot of developers it is more of a formality so it is rare thing to see serious discussions or review.
Within my team I encountered a developer who was not following the rutine and was commiting straight to the develop branch. I opened the topic of code reviews, then we started doing pull requests. My pull requests were automaticaly aproved. It was though obvious that he was not reading them , just pressing the button.
At the same time it apears he is taking it a bit personal when I am doing the reviews. I usualy do quite throughrough code reviews to be honest. I take it seriously. I have been doing code reviews to other developers in the company I work for it is just this one case where the developer apears to be extremly defensive. The problem is that we work very close.
Should I stop doing code reviews ? How to aproach this situation in a best way ?
Just one fresh example to get the point. The developer writes a class that looks like something in between Factory and Container then names it SomethingBuilder where the Something part is not related to the finaly built object. I of course comment on this and lets say he takes it personaly. What am I supposed to do here. It apears the Tech Lead of the team does not care. He defends him a lot actualy. He says everyone has it own style. I am not sure what kind of style it is to name Factory a Builder, but nevermind. Is avoidance the best strategy here, especialy when the Tech Lead shows compasion to the guy.
software-industry work-environment team software-development teamwork
asked 12 mins ago
Pesho
92
New contributor
Pesho is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |Â
up vote
1
down vote
favorite
I am in the following situation. Small team witin a large unit with many teams. There is officiel code review process,but to a lot of developers it is more of a formality so it is rare thing to see serious discussions or review.
Within my team I encountered a developer who was not following the rutine and was commiting straight to the develop branch. I opened the topic of code reviews, then we started doing pull requests. My pull requests were automaticaly aproved. It was though obvious that he was not reading them , just pressing the button.
At the same time it apears he is taking it a bit personal when I am doing the reviews. I usualy do quite throughrough code reviews to be honest. I take it seriously. I have been doing code reviews to other developers in the company I work for it is just this one case where the developer apears to be extremly defensive. The problem is that we work very close.
Should I stop doing code reviews ? How to aproach this situation in a best way ?
Just one fresh example to get the point. The developer writes a class that looks like something in between Factory and Container then names it SomethingBuilder where the Something part is not related to the finaly built object. I of course comment on this and lets say he takes it personaly. What am I supposed to do here. It apears the Tech Lead of the team does not care. He defends him a lot actualy. He says everyone has it own style. I am not sure what kind of style it is to name Factory a Builder, but nevermind. Is avoidance the best strategy here, especialy when the Tech Lead shows compasion to the guy.
software-industry work-environment team software-development teamwork
asked 12 mins ago
Pesho
92
New contributor
Pesho is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
what do you mean "a bit personal"? what do you mean "quite thorough" and "quite seriously", can you give an example of what you're rejecting or commenting on? what does "work very close" mean? physically? do you have a team lead in the team you can raise this to?
– bharal
10 mins ago
When I say throughrough, I mean that I am realy spending time to find the problems in the code and point out its weak points. I usualy avoid using the word "you" but reference the code itself.
– Pesho
8 mins ago
I mean I don`t do the reviews just formaly.
– Pesho
7 mins ago
are you just commenting on the class naming conventions? I can see how that would irritate someone - some developers use class names as an outlet for creativity. I think i once named a pattern matching class as "DeviceHarmoniser". If the worst example you can come up with in a code review is the naming of a class then I think it's safe to let that slide.
– bharal
2 mins ago
@bharal It is a very confusing class actualy. When you read it you expect a Builder that builds particular object. Then you realize it does not have the classic Builder api. Then you realize it is not actualy building what it says, and then you realize it does hell of a lot more than what it actualy Builds. It took me 30 min to understand the logic and I consider myself very fast code reader.
– Pesho
26 secs ago
add a comment |Â
up vote
1
down vote
favorite
up vote
1
down vote
favorite
I am in the following situation. Small team witin a large unit with many teams. There is officiel code review process,but to a lot of developers it is more of a formality so it is rare thing to see serious discussions or review.
Within my team I encountered a developer who was not following the rutine and was commiting straight to the develop branch. I opened the topic of code reviews, then we started doing pull requests. My pull requests were automaticaly aproved. It was though obvious that he was not reading them , just pressing the button.
At the same time it apears he is taking it a bit personal when I am doing the reviews. I usualy do quite throughrough code reviews to be honest. I take it seriously. I have been doing code reviews to other developers in the company I work for it is just this one case where the developer apears to be extremly defensive. The problem is that we work very close.
Should I stop doing code reviews ? How to aproach this situation in a best way ?
Just one fresh example to get the point. The developer writes a class that looks like something in between Factory and Container then names it SomethingBuilder where the Something part is not related to the finaly built object. I of course comment on this and lets say he takes it personaly. What am I supposed to do here. It apears the Tech Lead of the team does not care. He defends him a lot actualy. He says everyone has it own style. I am not sure what kind of style it is to name Factory a Builder, but nevermind. Is avoidance the best strategy here, especialy when the Tech Lead shows compasion to the guy.
software-industry work-environment team software-development teamwork
asked 12 mins ago
Pesho
92
New contributor
Pesho is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
I am in the following situation. Small team witin a large unit with many teams. There is officiel code review process,but to a lot of developers it is more of a formality so it is rare thing to see serious discussions or review.
Within my team I encountered a developer who was not following the rutine and was commiting straight to the develop branch. I opened the topic of code reviews, then we started doing pull requests. My pull requests were automaticaly aproved. It was though obvious that he was not reading them , just pressing the button.
At the same time it apears he is taking it a bit personal when I am doing the reviews. I usualy do quite throughrough code reviews to be honest. I take it seriously. I have been doing code reviews to other developers in the company I work for it is just this one case where the developer apears to be extremly defensive. The problem is that we work very close.
Should I stop doing code reviews ? How to aproach this situation in a best way ?
Just one fresh example to get the point. The developer writes a class that looks like something in between Factory and Container then names it SomethingBuilder where the Something part is not related to the finaly built object. I of course comment on this and lets say he takes it personaly. What am I supposed to do here. It apears the Tech Lead of the team does not care. He defends him a lot actualy. He says everyone has it own style. I am not sure what kind of style it is to name Factory a Builder, but nevermind. Is avoidance the best strategy here, especialy when the Tech Lead shows compasion to the guy.
software-industry work-environment team software-development teamwork
software-industry work-environment team software-development teamwork
asked 12 mins ago
Pesho
92
New contributor
Pesho is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 12 mins ago
Pesho
92
New contributor
Pesho is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited 4 mins ago
asked 12 mins ago
Pesho
92
New contributor
Pesho is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 12 mins ago
Pesho
92
asked 12 mins ago
Pesho
92
92
New contributor
Pesho is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
Pesho is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Pesho is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
what do you mean "a bit personal"? what do you mean "quite thorough" and "quite seriously", can you give an example of what you're rejecting or commenting on? what does "work very close" mean? physically? do you have a team lead in the team you can raise this to?
– bharal
10 mins ago
When I say throughrough, I mean that I am realy spending time to find the problems in the code and point out its weak points. I usualy avoid using the word "you" but reference the code itself.
– Pesho
8 mins ago
I mean I don`t do the reviews just formaly.
– Pesho
7 mins ago
are you just commenting on the class naming conventions? I can see how that would irritate someone - some developers use class names as an outlet for creativity. I think i once named a pattern matching class as "DeviceHarmoniser". If the worst example you can come up with in a code review is the naming of a class then I think it's safe to let that slide.
– bharal
2 mins ago
@bharal It is a very confusing class actualy. When you read it you expect a Builder that builds particular object. Then you realize it does not have the classic Builder api. Then you realize it is not actualy building what it says, and then you realize it does hell of a lot more than what it actualy Builds. It took me 30 min to understand the logic and I consider myself very fast code reader.
– Pesho
26 secs ago
add a comment |Â
what do you mean "a bit personal"? what do you mean "quite thorough" and "quite seriously", can you give an example of what you're rejecting or commenting on? what does "work very close" mean? physically? do you have a team lead in the team you can raise this to?
– bharal
10 mins ago
When I say throughrough, I mean that I am realy spending time to find the problems in the code and point out its weak points. I usualy avoid using the word "you" but reference the code itself.
– Pesho
8 mins ago
I mean I don`t do the reviews just formaly.
– Pesho
7 mins ago
are you just commenting on the class naming conventions? I can see how that would irritate someone - some developers use class names as an outlet for creativity. I think i once named a pattern matching class as "DeviceHarmoniser". If the worst example you can come up with in a code review is the naming of a class then I think it's safe to let that slide.
– bharal
2 mins ago
@bharal It is a very confusing class actualy. When you read it you expect a Builder that builds particular object. Then you realize it does not have the classic Builder api. Then you realize it is not actualy building what it says, and then you realize it does hell of a lot more than what it actualy Builds. It took me 30 min to understand the logic and I consider myself very fast code reader.
– Pesho
26 secs ago
what do you mean "a bit personal"? what do you mean "quite thorough" and "quite seriously", can you give an example of what you're rejecting or commenting on? what does "work very close" mean? physically? do you have a team lead in the team you can raise this to?
– bharal
10 mins ago
what do you mean "a bit personal"? what do you mean "quite thorough" and "quite seriously", can you give an example of what you're rejecting or commenting on? what does "work very close" mean? physically? do you have a team lead in the team you can raise this to?
– bharal
10 mins ago
When I say throughrough, I mean that I am realy spending time to find the problems in the code and point out its weak points. I usualy avoid using the word "you" but reference the code itself.
– Pesho
8 mins ago
When I say throughrough, I mean that I am realy spending time to find the problems in the code and point out its weak points. I usualy avoid using the word "you" but reference the code itself.
– Pesho
8 mins ago
I mean I don`t do the reviews just formaly.
– Pesho
7 mins ago
I mean I don`t do the reviews just formaly.
– Pesho
7 mins ago
are you just commenting on the class naming conventions? I can see how that would irritate someone - some developers use class names as an outlet for creativity. I think i once named a pattern matching class as "DeviceHarmoniser". If the worst example you can come up with in a code review is the naming of a class then I think it's safe to let that slide.
– bharal
2 mins ago
are you just commenting on the class naming conventions? I can see how that would irritate someone - some developers use class names as an outlet for creativity. I think i once named a pattern matching class as "DeviceHarmoniser". If the worst example you can come up with in a code review is the naming of a class then I think it's safe to let that slide.
– bharal
2 mins ago
@bharal It is a very confusing class actualy. When you read it you expect a Builder that builds particular object. Then you realize it does not have the classic Builder api. Then you realize it is not actualy building what it says, and then you realize it does hell of a lot more than what it actualy Builds. It took me 30 min to understand the logic and I consider myself very fast code reader.
– Pesho
26 secs ago
@bharal It is a very confusing class actualy. When you read it you expect a Builder that builds particular object. Then you realize it does not have the classic Builder api. Then you realize it is not actualy building what it says, and then you realize it does hell of a lot more than what it actualy Builds. It took me 30 min to understand the logic and I consider myself very fast code reader.
– Pesho
26 secs ago
add a comment |Â
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
Pesho is a new contributor. Be nice, and check out our Code of Conduct.
Pesho is a new contributor. Be nice, and check out our Code of Conduct.
Pesho is a new contributor. Be nice, and check out our Code of Conduct.
Pesho is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fworkplace.stackexchange.com%2fquestions%2f121672%2fcode-reviewing-hostile-developer%23new-answer', 'question_page');
);
Post as a guest
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
what do you mean "a bit personal"? what do you mean "quite thorough" and "quite seriously", can you give an example of what you're rejecting or commenting on? what does "work very close" mean? physically? do you have a team lead in the team you can raise this to?
– bharal
10 mins ago
When I say throughrough, I mean that I am realy spending time to find the problems in the code and point out its weak points. I usualy avoid using the word "you" but reference the code itself.
– Pesho
8 mins ago
I mean I don`t do the reviews just formaly.
– Pesho
7 mins ago
are you just commenting on the class naming conventions? I can see how that would irritate someone - some developers use class names as an outlet for creativity. I think i once named a pattern matching class as "DeviceHarmoniser". If the worst example you can come up with in a code review is the naming of a class then I think it's safe to let that slide.
– bharal
2 mins ago
@bharal It is a very confusing class actualy. When you read it you expect a Builder that builds particular object. Then you realize it does not have the classic Builder api. Then you realize it is not actualy building what it says, and then you realize it does hell of a lot more than what it actualy Builds. It took me 30 min to understand the logic and I consider myself very fast code reader.
– Pesho
26 secs ago