coworkers unwilling to do code reviews

Clash Royale CLAN TAG#URR8PPP

.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty margin-bottom:0;

up vote
0
down vote

favorite

At work I've been temporary lended to another team this quarter because they have too much work on their plate. I'm here to work on subject X for this team, that is kinda stand-alone but would benefit the team overall and was required by them.

The way we work with code in my company is that we have a repository by team (roughly) and that each commit has to go through a code review phase in gerrit first before in can be merged in the team's repo. The only people with the power to accept merging the pending commit in the repo are the people from the team. We also have the informal rule that no commit should be left un-reviewed more than 24 hours or so.

Now, in the past 10 days or so I have pushed 15+ commits, and got almost no feedback on any of them. At best, my initial commit was merged but I still have 14 commit unmerged that have been requiring code review for over a week.

What can I do to address this? The team I work with is composed of 3 people, one is senior enough to do the reviews but would prefer if the other juniors would ramp up and do the reviews. The other 2 juniors are really reluctant to do the review as they feel they can't understand the code enough due to lack of real knowledge in the language and as a result they won't take the responsability to approve my code.

For the last ~5 days my status at the stand-up has been "I'm stuck due to no code reviews", and I've even booked a 30 min meeting to walk the team through the code and explain what I was doing in the reviews. Now I'm at a point where I won't do any further work as it's too complex to work on a giant stack of accumulated commits whose code could change.

Any idea on how to solve this?
thanks!

colleagues team conflict teamwork coworker

share

asked 49 secs ago

throwaway_account

1

New contributor

throwaway_account is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

add a comment | 

up vote
0
down vote

favorite

At work I've been temporary lended to another team this quarter because they have too much work on their plate. I'm here to work on subject X for this team, that is kinda stand-alone but would benefit the team overall and was required by them.

The way we work with code in my company is that we have a repository by team (roughly) and that each commit has to go through a code review phase in gerrit first before in can be merged in the team's repo. The only people with the power to accept merging the pending commit in the repo are the people from the team. We also have the informal rule that no commit should be left un-reviewed more than 24 hours or so.

Now, in the past 10 days or so I have pushed 15+ commits, and got almost no feedback on any of them. At best, my initial commit was merged but I still have 14 commit unmerged that have been requiring code review for over a week.

What can I do to address this? The team I work with is composed of 3 people, one is senior enough to do the reviews but would prefer if the other juniors would ramp up and do the reviews. The other 2 juniors are really reluctant to do the review as they feel they can't understand the code enough due to lack of real knowledge in the language and as a result they won't take the responsability to approve my code.

For the last ~5 days my status at the stand-up has been "I'm stuck due to no code reviews", and I've even booked a 30 min meeting to walk the team through the code and explain what I was doing in the reviews. Now I'm at a point where I won't do any further work as it's too complex to work on a giant stack of accumulated commits whose code could change.

Any idea on how to solve this?
thanks!

colleagues team conflict teamwork coworker

share

asked 49 secs ago

throwaway_account

1

New contributor

throwaway_account is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

add a comment | 

up vote
0
down vote

favorite

up vote
0
down vote

favorite

At work I've been temporary lended to another team this quarter because they have too much work on their plate. I'm here to work on subject X for this team, that is kinda stand-alone but would benefit the team overall and was required by them.

The way we work with code in my company is that we have a repository by team (roughly) and that each commit has to go through a code review phase in gerrit first before in can be merged in the team's repo. The only people with the power to accept merging the pending commit in the repo are the people from the team. We also have the informal rule that no commit should be left un-reviewed more than 24 hours or so.

Now, in the past 10 days or so I have pushed 15+ commits, and got almost no feedback on any of them. At best, my initial commit was merged but I still have 14 commit unmerged that have been requiring code review for over a week.

What can I do to address this? The team I work with is composed of 3 people, one is senior enough to do the reviews but would prefer if the other juniors would ramp up and do the reviews. The other 2 juniors are really reluctant to do the review as they feel they can't understand the code enough due to lack of real knowledge in the language and as a result they won't take the responsability to approve my code.

For the last ~5 days my status at the stand-up has been "I'm stuck due to no code reviews", and I've even booked a 30 min meeting to walk the team through the code and explain what I was doing in the reviews. Now I'm at a point where I won't do any further work as it's too complex to work on a giant stack of accumulated commits whose code could change.

Any idea on how to solve this?
thanks!

colleagues team conflict teamwork coworker

share

asked 49 secs ago

throwaway_account

1

New contributor

throwaway_account is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

At work I've been temporary lended to another team this quarter because they have too much work on their plate. I'm here to work on subject X for this team, that is kinda stand-alone but would benefit the team overall and was required by them.

The way we work with code in my company is that we have a repository by team (roughly) and that each commit has to go through a code review phase in gerrit first before in can be merged in the team's repo. The only people with the power to accept merging the pending commit in the repo are the people from the team. We also have the informal rule that no commit should be left un-reviewed more than 24 hours or so.

Now, in the past 10 days or so I have pushed 15+ commits, and got almost no feedback on any of them. At best, my initial commit was merged but I still have 14 commit unmerged that have been requiring code review for over a week.

What can I do to address this? The team I work with is composed of 3 people, one is senior enough to do the reviews but would prefer if the other juniors would ramp up and do the reviews. The other 2 juniors are really reluctant to do the review as they feel they can't understand the code enough due to lack of real knowledge in the language and as a result they won't take the responsability to approve my code.

For the last ~5 days my status at the stand-up has been "I'm stuck due to no code reviews", and I've even booked a 30 min meeting to walk the team through the code and explain what I was doing in the reviews. Now I'm at a point where I won't do any further work as it's too complex to work on a giant stack of accumulated commits whose code could change.

Any idea on how to solve this?
thanks!

colleagues team conflict teamwork coworker

colleagues team conflict teamwork coworker

share

asked 49 secs ago

throwaway_account

1

New contributor

throwaway_account is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

share

asked 49 secs ago

throwaway_account

1

New contributor

throwaway_account is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

share

share

asked 49 secs ago

throwaway_account

1

New contributor

throwaway_account is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

asked 49 secs ago

throwaway_account

1

asked 49 secs ago

throwaway_account

1

1

New contributor

throwaway_account is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

New contributor

throwaway_account is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

throwaway_account is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

add a comment | 

add a comment | 

active

oldest

votes

Your Answer

StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "423"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);

else
createEditor();

);

function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
convertImagesToLinks: false,
noModals: false,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
noCode: true, onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);



);

throwaway_account is a new contributor. Be nice, and check out our Code of Conduct.

 

draft saved

draft discarded

Sign up or log in

StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);

Sign up using Google

Sign up using Facebook

Sign up using Email and Password

Post as a guest

Name Email

StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fworkplace.stackexchange.com%2fquestions%2f121376%2fcoworkers-unwilling-to-do-code-reviews%23new-answer', 'question_page');

);

Post as a guest

Name Email

active

oldest

votes

active

oldest

votes

active

oldest

votes

active

oldest

votes

throwaway_account is a new contributor. Be nice, and check out our Code of Conduct.

 

draft saved

draft discarded

throwaway_account is a new contributor. Be nice, and check out our Code of Conduct.

throwaway_account is a new contributor. Be nice, and check out our Code of Conduct.

throwaway_account is a new contributor. Be nice, and check out our Code of Conduct.

 

draft saved

draft discarded

Sign up or log in

StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);

Sign up using Google

Sign up using Facebook

Sign up using Email and Password

Post as a guest

Name Email

StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fworkplace.stackexchange.com%2fquestions%2f121376%2fcoworkers-unwilling-to-do-code-reviews%23new-answer', 'question_page');

);

Post as a guest

Name Email

Sign up or log in

StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);

Sign up using Google

Sign up using Facebook

Sign up using Email and Password

Post as a guest

Name Email

Sign up or log in

StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);

Sign up using Google

Sign up using Facebook

Sign up using Email and Password

Post as a guest

Name Email

Sign up or log in

StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);

Sign up using Google

Sign up using Facebook

Sign up using Email and Password

Sign up using Google

Sign up using Facebook

Sign up using Email and Password

Post as a guest

Name Email

Name Email

Name

Email

Name Email

Name

Email