How best to approach a situation where a project you've been working on has been given over to someone else?
Clash Royale CLAN TAG#URR8PPP
.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty margin-bottom:0;
up vote
0
down vote
favorite
I'm a web developer. For a month or so I worked (on and off) on a project at my work. I completed it and submitted it for code review, as is normal procedure at my work. Code review allows other senior developers to look over the work and make sure you're not releasing any potential bugs.
The person reviewing my work noted a lot of mistakes and 'rejected' the work and handed it over to another developer. Looking through their notes I see that their comments are correct, but most of them are very minor and quick fixes. It doesn't seem that out-of-the ordinary for a code review (most do come back with comments).
I asked the reviewer why they had taken the project from me and their answer was vague, along the lines of "priorities have changed".
I feel quite upset that not only was my project I had devoted a lot of time to had not only been officially 'rejected' on normal and minor code changes, but also that it was given over to someone else. Further more, due to the companies com system other have been made aware of my 'failure'.
I know the reviewer quite well and know they did not do this as a personal grudge against me, but I do think they came on too heavy handed.
First off, am I over-reacting? My pride is hurt definitely, I feel, honestly, pretty down about it having put so many hours and care into and having obviously not earned the trust of the reviewer to fix the mistakes.
How should I handle this situation? Should I approach the reviewer even though they may not like me challenging them?
management review
add a comment |Â
up vote
0
down vote
favorite
I'm a web developer. For a month or so I worked (on and off) on a project at my work. I completed it and submitted it for code review, as is normal procedure at my work. Code review allows other senior developers to look over the work and make sure you're not releasing any potential bugs.
The person reviewing my work noted a lot of mistakes and 'rejected' the work and handed it over to another developer. Looking through their notes I see that their comments are correct, but most of them are very minor and quick fixes. It doesn't seem that out-of-the ordinary for a code review (most do come back with comments).
I asked the reviewer why they had taken the project from me and their answer was vague, along the lines of "priorities have changed".
I feel quite upset that not only was my project I had devoted a lot of time to had not only been officially 'rejected' on normal and minor code changes, but also that it was given over to someone else. Further more, due to the companies com system other have been made aware of my 'failure'.
I know the reviewer quite well and know they did not do this as a personal grudge against me, but I do think they came on too heavy handed.
First off, am I over-reacting? My pride is hurt definitely, I feel, honestly, pretty down about it having put so many hours and care into and having obviously not earned the trust of the reviewer to fix the mistakes.
How should I handle this situation? Should I approach the reviewer even though they may not like me challenging them?
management review
@Kilisi How do you mean exactly?
– MeltingDog
Aug 9 at 8:33
add a comment |Â
up vote
0
down vote
favorite
up vote
0
down vote
favorite
I'm a web developer. For a month or so I worked (on and off) on a project at my work. I completed it and submitted it for code review, as is normal procedure at my work. Code review allows other senior developers to look over the work and make sure you're not releasing any potential bugs.
The person reviewing my work noted a lot of mistakes and 'rejected' the work and handed it over to another developer. Looking through their notes I see that their comments are correct, but most of them are very minor and quick fixes. It doesn't seem that out-of-the ordinary for a code review (most do come back with comments).
I asked the reviewer why they had taken the project from me and their answer was vague, along the lines of "priorities have changed".
I feel quite upset that not only was my project I had devoted a lot of time to had not only been officially 'rejected' on normal and minor code changes, but also that it was given over to someone else. Further more, due to the companies com system other have been made aware of my 'failure'.
I know the reviewer quite well and know they did not do this as a personal grudge against me, but I do think they came on too heavy handed.
First off, am I over-reacting? My pride is hurt definitely, I feel, honestly, pretty down about it having put so many hours and care into and having obviously not earned the trust of the reviewer to fix the mistakes.
How should I handle this situation? Should I approach the reviewer even though they may not like me challenging them?
management review
I'm a web developer. For a month or so I worked (on and off) on a project at my work. I completed it and submitted it for code review, as is normal procedure at my work. Code review allows other senior developers to look over the work and make sure you're not releasing any potential bugs.
The person reviewing my work noted a lot of mistakes and 'rejected' the work and handed it over to another developer. Looking through their notes I see that their comments are correct, but most of them are very minor and quick fixes. It doesn't seem that out-of-the ordinary for a code review (most do come back with comments).
I asked the reviewer why they had taken the project from me and their answer was vague, along the lines of "priorities have changed".
I feel quite upset that not only was my project I had devoted a lot of time to had not only been officially 'rejected' on normal and minor code changes, but also that it was given over to someone else. Further more, due to the companies com system other have been made aware of my 'failure'.
I know the reviewer quite well and know they did not do this as a personal grudge against me, but I do think they came on too heavy handed.
First off, am I over-reacting? My pride is hurt definitely, I feel, honestly, pretty down about it having put so many hours and care into and having obviously not earned the trust of the reviewer to fix the mistakes.
How should I handle this situation? Should I approach the reviewer even though they may not like me challenging them?
management review
asked Aug 8 at 14:18


MeltingDog
9362912
9362912
@Kilisi How do you mean exactly?
– MeltingDog
Aug 9 at 8:33
add a comment |Â
@Kilisi How do you mean exactly?
– MeltingDog
Aug 9 at 8:33
@Kilisi How do you mean exactly?
– MeltingDog
Aug 9 at 8:33
@Kilisi How do you mean exactly?
– MeltingDog
Aug 9 at 8:33
add a comment |Â
1 Answer
1
active
oldest
votes
up vote
2
down vote
accepted
Just carry on.
Never take things personal, you are doing a job and doing it the best you can. Especially that a month or so is not a lot of time.
So, as long as you are getting the feedback through comments, learn from them and move forward. Put a personal goal for your self, that your bugs, whether small or big, should go to the minimal possible. Then, use the comments/reviews as your metric system to measure your progress.
add a comment |Â
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
up vote
2
down vote
accepted
Just carry on.
Never take things personal, you are doing a job and doing it the best you can. Especially that a month or so is not a lot of time.
So, as long as you are getting the feedback through comments, learn from them and move forward. Put a personal goal for your self, that your bugs, whether small or big, should go to the minimal possible. Then, use the comments/reviews as your metric system to measure your progress.
add a comment |Â
up vote
2
down vote
accepted
Just carry on.
Never take things personal, you are doing a job and doing it the best you can. Especially that a month or so is not a lot of time.
So, as long as you are getting the feedback through comments, learn from them and move forward. Put a personal goal for your self, that your bugs, whether small or big, should go to the minimal possible. Then, use the comments/reviews as your metric system to measure your progress.
add a comment |Â
up vote
2
down vote
accepted
up vote
2
down vote
accepted
Just carry on.
Never take things personal, you are doing a job and doing it the best you can. Especially that a month or so is not a lot of time.
So, as long as you are getting the feedback through comments, learn from them and move forward. Put a personal goal for your self, that your bugs, whether small or big, should go to the minimal possible. Then, use the comments/reviews as your metric system to measure your progress.
Just carry on.
Never take things personal, you are doing a job and doing it the best you can. Especially that a month or so is not a lot of time.
So, as long as you are getting the feedback through comments, learn from them and move forward. Put a personal goal for your self, that your bugs, whether small or big, should go to the minimal possible. Then, use the comments/reviews as your metric system to measure your progress.
answered Aug 8 at 14:22
Sandra K
5,82562043
5,82562043
add a comment |Â
add a comment |Â
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fworkplace.stackexchange.com%2fquestions%2f117204%2fhow-best-to-approach-a-situation-where-a-project-youve-been-working-on-has-been%23new-answer', 'question_page');
);
Post as a guest
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
@Kilisi How do you mean exactly?
– MeltingDog
Aug 9 at 8:33