Mixing
Asked to do my job simpler [closed]
Clash Royale CLAN TAG#URR8PPP
.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty margin-bottom:0;
up vote
1
down vote
favorite
I recently was asked by a senior colleague ('Steve') to help him on a project he didn't have a time for: modify his old code to fulfill new requirements. He also asked me to change little, but agreed that it will be hard to do.
The code was hard to navigate and understand. It was a lot of copy-pastes. I decided to do both jobs - to provide a minimal modified code with new functionality, and to do refactoring and propose a better way.
He didn't like what I've done. He didn't even want to read the code, he glanced at it and told me he didn't understand it. He wants me to write simple code because he or his team are not used to use more complex structures. He agrees that their code is bad, but he doesn't want to change anything - this works for his team.
Then he asked me to always conform to his code style. He said he knew this will be hard for me.
I can't agree to do that always. I feel like I am asked to do a bad job, and if I am doing that, each second I will be thinking of doing a wrong thing.
(A bit of context: I worked with Steve for almost 5 years, but we never had a common code base. He works in the company for almost 20 years, and is a respectful specialist. I also respect him a lot. Previously I was located in another office, and moved to the main office just recently. Steve and his team are mostly HW engineers, that had to become SW, so that's why their code is like that. The whole company is HW engineers, so I do not have much support for trying to introduce better code quality. And changing the job or even project is a no go for me. I think the company has put a lot of efforts in my move (and I wanted that move), and their reason as I understand was in helping Steve with his projects. I am considered partially as a part of Steve's team now. Officially Steve is not a team leader, he has the same position as I do, but given that he is working with this stuff for 20 years, he often is considered as a leader.)
Update
This was a new project. I had to take his code base, and implement it in a new project by changing the protocol it works with. But given that I have to support this project further, I wanted to make it more supportable. I'm not worried about this concrete situation, but I would not like to be forced into it once again.
My questions:
- Am I right in my views?
- What should I do so I won't get into such situations any more?
If I am right, then I'd like to find some compromise between my and his views (it looks like neither me nor he are ready to change the views completely). So how do I put things and find such compromise, without offending him and doing more bad than good?
professionalism software-industry team
edited Jul 21 '16 at 13:23
Jan Doggen
11.5k145066
asked Jul 21 '16 at 10:02
Peter
112
closed as off-topic by Lilienthal♦, nvoigt, Jim G., scaaahu, paparazzo Jul 21 '16 at 11:35
This question appears to be off-topic. The users who voted to close gave this specific reason:
- "Real questions have answers. Rather than explaining why your situation is terrible, or why your boss/coworker makes you unhappy, explain what you want to do to make it better. For more information, click here." – Lilienthal, nvoigt, Jim G., scaaahu, paparazzo
suggest improvements |Â
up vote
1
down vote
favorite
I recently was asked by a senior colleague ('Steve') to help him on a project he didn't have a time for: modify his old code to fulfill new requirements. He also asked me to change little, but agreed that it will be hard to do.
The code was hard to navigate and understand. It was a lot of copy-pastes. I decided to do both jobs - to provide a minimal modified code with new functionality, and to do refactoring and propose a better way.
He didn't like what I've done. He didn't even want to read the code, he glanced at it and told me he didn't understand it. He wants me to write simple code because he or his team are not used to use more complex structures. He agrees that their code is bad, but he doesn't want to change anything - this works for his team.
Then he asked me to always conform to his code style. He said he knew this will be hard for me.
I can't agree to do that always. I feel like I am asked to do a bad job, and if I am doing that, each second I will be thinking of doing a wrong thing.
(A bit of context: I worked with Steve for almost 5 years, but we never had a common code base. He works in the company for almost 20 years, and is a respectful specialist. I also respect him a lot. Previously I was located in another office, and moved to the main office just recently. Steve and his team are mostly HW engineers, that had to become SW, so that's why their code is like that. The whole company is HW engineers, so I do not have much support for trying to introduce better code quality. And changing the job or even project is a no go for me. I think the company has put a lot of efforts in my move (and I wanted that move), and their reason as I understand was in helping Steve with his projects. I am considered partially as a part of Steve's team now. Officially Steve is not a team leader, he has the same position as I do, but given that he is working with this stuff for 20 years, he often is considered as a leader.)
Update
This was a new project. I had to take his code base, and implement it in a new project by changing the protocol it works with. But given that I have to support this project further, I wanted to make it more supportable. I'm not worried about this concrete situation, but I would not like to be forced into it once again.
My questions:
- Am I right in my views?
- What should I do so I won't get into such situations any more?
If I am right, then I'd like to find some compromise between my and his views (it looks like neither me nor he are ready to change the views completely). So how do I put things and find such compromise, without offending him and doing more bad than good?
professionalism software-industry team
edited Jul 21 '16 at 13:23
Jan Doggen
11.5k145066
asked Jul 21 '16 at 10:02
Peter
112
closed as off-topic by Lilienthal♦, nvoigt, Jim G., scaaahu, paparazzo Jul 21 '16 at 11:35
This question appears to be off-topic. The users who voted to close gave this specific reason:
- "Real questions have answers. Rather than explaining why your situation is terrible, or why your boss/coworker makes you unhappy, explain what you want to do to make it better. For more information, click here." – Lilienthal, nvoigt, Jim G., scaaahu, paparazzo
Comments are not for extended discussion; this conversation has been moved to chat.
– Jane S♦
Jul 23 '16 at 5:48
if things are the way you say they are, maybe find a new workplace where you'll fit in better (read: where they'll appreciate your work)
– René Roth
Jun 9 at 15:01
suggest improvements |Â
up vote
1
down vote
favorite
up vote
1
down vote
favorite
I recently was asked by a senior colleague ('Steve') to help him on a project he didn't have a time for: modify his old code to fulfill new requirements. He also asked me to change little, but agreed that it will be hard to do.
The code was hard to navigate and understand. It was a lot of copy-pastes. I decided to do both jobs - to provide a minimal modified code with new functionality, and to do refactoring and propose a better way.
He didn't like what I've done. He didn't even want to read the code, he glanced at it and told me he didn't understand it. He wants me to write simple code because he or his team are not used to use more complex structures. He agrees that their code is bad, but he doesn't want to change anything - this works for his team.
Then he asked me to always conform to his code style. He said he knew this will be hard for me.
I can't agree to do that always. I feel like I am asked to do a bad job, and if I am doing that, each second I will be thinking of doing a wrong thing.
(A bit of context: I worked with Steve for almost 5 years, but we never had a common code base. He works in the company for almost 20 years, and is a respectful specialist. I also respect him a lot. Previously I was located in another office, and moved to the main office just recently. Steve and his team are mostly HW engineers, that had to become SW, so that's why their code is like that. The whole company is HW engineers, so I do not have much support for trying to introduce better code quality. And changing the job or even project is a no go for me. I think the company has put a lot of efforts in my move (and I wanted that move), and their reason as I understand was in helping Steve with his projects. I am considered partially as a part of Steve's team now. Officially Steve is not a team leader, he has the same position as I do, but given that he is working with this stuff for 20 years, he often is considered as a leader.)
Update
This was a new project. I had to take his code base, and implement it in a new project by changing the protocol it works with. But given that I have to support this project further, I wanted to make it more supportable. I'm not worried about this concrete situation, but I would not like to be forced into it once again.
My questions:
- Am I right in my views?
- What should I do so I won't get into such situations any more?
If I am right, then I'd like to find some compromise between my and his views (it looks like neither me nor he are ready to change the views completely). So how do I put things and find such compromise, without offending him and doing more bad than good?
professionalism software-industry team
edited Jul 21 '16 at 13:23
Jan Doggen
11.5k145066
asked Jul 21 '16 at 10:02
Peter
112
I recently was asked by a senior colleague ('Steve') to help him on a project he didn't have a time for: modify his old code to fulfill new requirements. He also asked me to change little, but agreed that it will be hard to do.
The code was hard to navigate and understand. It was a lot of copy-pastes. I decided to do both jobs - to provide a minimal modified code with new functionality, and to do refactoring and propose a better way.
He didn't like what I've done. He didn't even want to read the code, he glanced at it and told me he didn't understand it. He wants me to write simple code because he or his team are not used to use more complex structures. He agrees that their code is bad, but he doesn't want to change anything - this works for his team.
Then he asked me to always conform to his code style. He said he knew this will be hard for me.
I can't agree to do that always. I feel like I am asked to do a bad job, and if I am doing that, each second I will be thinking of doing a wrong thing.
(A bit of context: I worked with Steve for almost 5 years, but we never had a common code base. He works in the company for almost 20 years, and is a respectful specialist. I also respect him a lot. Previously I was located in another office, and moved to the main office just recently. Steve and his team are mostly HW engineers, that had to become SW, so that's why their code is like that. The whole company is HW engineers, so I do not have much support for trying to introduce better code quality. And changing the job or even project is a no go for me. I think the company has put a lot of efforts in my move (and I wanted that move), and their reason as I understand was in helping Steve with his projects. I am considered partially as a part of Steve's team now. Officially Steve is not a team leader, he has the same position as I do, but given that he is working with this stuff for 20 years, he often is considered as a leader.)
Update
This was a new project. I had to take his code base, and implement it in a new project by changing the protocol it works with. But given that I have to support this project further, I wanted to make it more supportable. I'm not worried about this concrete situation, but I would not like to be forced into it once again.
My questions:
- Am I right in my views?
- What should I do so I won't get into such situations any more?
If I am right, then I'd like to find some compromise between my and his views (it looks like neither me nor he are ready to change the views completely). So how do I put things and find such compromise, without offending him and doing more bad than good?
professionalism software-industry team
edited Jul 21 '16 at 13:23
Jan Doggen
11.5k145066
asked Jul 21 '16 at 10:02
Peter
112
edited Jul 21 '16 at 13:23
Jan Doggen
11.5k145066
edited Jul 21 '16 at 13:23
Jan Doggen
11.5k145066
edited Jul 21 '16 at 13:23
Jan Doggen
11.5k145066
11.5k145066
asked Jul 21 '16 at 10:02
Peter
112
asked Jul 21 '16 at 10:02
Peter
112
asked Jul 21 '16 at 10:02
Peter
112
112
closed as off-topic by Lilienthal♦, nvoigt, Jim G., scaaahu, paparazzo Jul 21 '16 at 11:35
This question appears to be off-topic. The users who voted to close gave this specific reason:
- "Real questions have answers. Rather than explaining why your situation is terrible, or why your boss/coworker makes you unhappy, explain what you want to do to make it better. For more information, click here." – Lilienthal, nvoigt, Jim G., scaaahu, paparazzo
closed as off-topic by Lilienthal♦, nvoigt, Jim G., scaaahu, paparazzo Jul 21 '16 at 11:35
This question appears to be off-topic. The users who voted to close gave this specific reason:
- "Real questions have answers. Rather than explaining why your situation is terrible, or why your boss/coworker makes you unhappy, explain what you want to do to make it better. For more information, click here." – Lilienthal, nvoigt, Jim G., scaaahu, paparazzo
Comments are not for extended discussion; this conversation has been moved to chat.
– Jane S♦
Jul 23 '16 at 5:48
if things are the way you say they are, maybe find a new workplace where you'll fit in better (read: where they'll appreciate your work)
– René Roth
Jun 9 at 15:01
suggest improvements |Â
Comments are not for extended discussion; this conversation has been moved to chat.
– Jane S♦
Jul 23 '16 at 5:48
if things are the way you say they are, maybe find a new workplace where you'll fit in better (read: where they'll appreciate your work)
– René Roth
Jun 9 at 15:01
Comments are not for extended discussion; this conversation has been moved to chat.
– Jane S♦
Jul 23 '16 at 5:48
Comments are not for extended discussion; this conversation has been moved to chat.
– Jane S♦
Jul 23 '16 at 5:48
if things are the way you say they are, maybe find a new workplace where you'll fit in better (read: where they'll appreciate your work)
– René Roth
Jun 9 at 15:01
if things are the way you say they are, maybe find a new workplace where you'll fit in better (read: where they'll appreciate your work)
– René Roth
Jun 9 at 15:01
suggest improvements |Â
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
Comments are not for extended discussion; this conversation has been moved to chat.
– Jane S♦
Jul 23 '16 at 5:48
if things are the way you say they are, maybe find a new workplace where you'll fit in better (read: where they'll appreciate your work)
– René Roth
Jun 9 at 15:01