Mixing
![Changing jobs at the end of a year? hiring availability [closed]](https://blogger.googleusercontent.com/img/b/R29vZ2xl/AVvXsEgjbpfN9tAutmK93bJRC3ZoROZzi2TJDms5n8_qJuhgE0a9b52OOHayv3NGT8igAdFL7byXNst-_1DZK5SjrIJ28_6RQPUpBROqMs5s6jo-ZsjX8kjDwfxJufIitH3TaQRXWaGSQKRQib-f/s72-c/1.jpg)
How good does code have to be before sending it for code review? [closed]
Clash Royale CLAN TAG#URR8PPP
.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty margin-bottom:0;
up vote
2
down vote
favorite
I am an intern at a software company, and someone told me to send my code out for review. My code, although functional for my current purposes, is not ready to be merged into the master branch, and contains a lot of logging statements and random stuff that should never see the light of day.
For example, I replaced one of the parameters in a function call with the number "1000" because I wasn't sure how to set the value in a more principled way. Also, the latency is really bad, so it would require substantial improvements before I could even think about deploying it.
Should I still send it for review? I am scared people will think I am wasting their time, and/or realize I'm a bad programmer.
software-industry
edited Dec 9 '15 at 8:35
JakeGould
6,5721739
asked Dec 9 '15 at 7:32
user44796
1213
closed as off-topic by Dawny33, gnat, Lilienthal♦, Jane S♦ Dec 9 '15 at 10:20
This question appears to be off-topic. The users who voted to close gave this specific reason:
- "Questions asking for advice on what to do are not practical answerable questions (e.g. "what job should I take?", or "what skills should I learn?"). Questions should get answers explaining why and how to make a decision, not advice on what to do. For more information, click here." – Dawny33, gnat, Jane S
 |Â
show 3 more comments
up vote
2
down vote
favorite
I am an intern at a software company, and someone told me to send my code out for review. My code, although functional for my current purposes, is not ready to be merged into the master branch, and contains a lot of logging statements and random stuff that should never see the light of day.
For example, I replaced one of the parameters in a function call with the number "1000" because I wasn't sure how to set the value in a more principled way. Also, the latency is really bad, so it would require substantial improvements before I could even think about deploying it.
Should I still send it for review? I am scared people will think I am wasting their time, and/or realize I'm a bad programmer.
software-industry
edited Dec 9 '15 at 8:35
JakeGould
6,5721739
asked Dec 9 '15 at 7:32
user44796
1213
closed as off-topic by Dawny33, gnat, Lilienthal♦, Jane S♦ Dec 9 '15 at 10:20
This question appears to be off-topic. The users who voted to close gave this specific reason:
- "Questions asking for advice on what to do are not practical answerable questions (e.g. "what job should I take?", or "what skills should I learn?"). Questions should get answers explaining why and how to make a decision, not advice on what to do. For more information, click here." – Dawny33, gnat, Jane S
1
When you know that your code is below mediocre quality, then why do you want to send it for the review? Trust me, this would piss off the reviewer real bad. (Knowing the mistake and not rectifying)
– Dawny33
Dec 9 '15 at 7:36
Well they told me to send my code out for review a week ago, and I don't want them to think I'm not following orders.
– user44796
Dec 9 '15 at 7:37
3
You could have informed this to your mentor before, when they asked you for a code review. It's not late now, but don't expect a very positive response now. A week is a lot of wasted time at production.
– Dawny33
Dec 9 '15 at 7:40
2
This question may be a better fit for Software Engineering
– Jan Doggen
Dec 9 '15 at 8:07
5
you have had a week and not cleaned it up?
– Kilisi
Dec 9 '15 at 8:23
 |Â
show 3 more comments
up vote
2
down vote
favorite
up vote
2
down vote
favorite
I am an intern at a software company, and someone told me to send my code out for review. My code, although functional for my current purposes, is not ready to be merged into the master branch, and contains a lot of logging statements and random stuff that should never see the light of day.
For example, I replaced one of the parameters in a function call with the number "1000" because I wasn't sure how to set the value in a more principled way. Also, the latency is really bad, so it would require substantial improvements before I could even think about deploying it.
Should I still send it for review? I am scared people will think I am wasting their time, and/or realize I'm a bad programmer.
software-industry
edited Dec 9 '15 at 8:35
JakeGould
6,5721739
asked Dec 9 '15 at 7:32
user44796
1213
I am an intern at a software company, and someone told me to send my code out for review. My code, although functional for my current purposes, is not ready to be merged into the master branch, and contains a lot of logging statements and random stuff that should never see the light of day.
For example, I replaced one of the parameters in a function call with the number "1000" because I wasn't sure how to set the value in a more principled way. Also, the latency is really bad, so it would require substantial improvements before I could even think about deploying it.
Should I still send it for review? I am scared people will think I am wasting their time, and/or realize I'm a bad programmer.
software-industry
edited Dec 9 '15 at 8:35
JakeGould
6,5721739
asked Dec 9 '15 at 7:32
user44796
1213
edited Dec 9 '15 at 8:35
JakeGould
6,5721739
edited Dec 9 '15 at 8:35
JakeGould
6,5721739
edited Dec 9 '15 at 8:35
JakeGould
6,5721739
6,5721739
asked Dec 9 '15 at 7:32
user44796
1213
asked Dec 9 '15 at 7:32
user44796
1213
asked Dec 9 '15 at 7:32
user44796
1213
1213
closed as off-topic by Dawny33, gnat, Lilienthal♦, Jane S♦ Dec 9 '15 at 10:20
This question appears to be off-topic. The users who voted to close gave this specific reason:
- "Questions asking for advice on what to do are not practical answerable questions (e.g. "what job should I take?", or "what skills should I learn?"). Questions should get answers explaining why and how to make a decision, not advice on what to do. For more information, click here." – Dawny33, gnat, Jane S
closed as off-topic by Dawny33, gnat, Lilienthal♦, Jane S♦ Dec 9 '15 at 10:20
This question appears to be off-topic. The users who voted to close gave this specific reason:
- "Questions asking for advice on what to do are not practical answerable questions (e.g. "what job should I take?", or "what skills should I learn?"). Questions should get answers explaining why and how to make a decision, not advice on what to do. For more information, click here." – Dawny33, gnat, Jane S
1
When you know that your code is below mediocre quality, then why do you want to send it for the review? Trust me, this would piss off the reviewer real bad. (Knowing the mistake and not rectifying)
– Dawny33
Dec 9 '15 at 7:36
Well they told me to send my code out for review a week ago, and I don't want them to think I'm not following orders.
– user44796
Dec 9 '15 at 7:37
3
You could have informed this to your mentor before, when they asked you for a code review. It's not late now, but don't expect a very positive response now. A week is a lot of wasted time at production.
– Dawny33
Dec 9 '15 at 7:40
2
This question may be a better fit for Software Engineering
– Jan Doggen
Dec 9 '15 at 8:07
5
you have had a week and not cleaned it up?
– Kilisi
Dec 9 '15 at 8:23
 |Â
show 3 more comments
1
When you know that your code is below mediocre quality, then why do you want to send it for the review? Trust me, this would piss off the reviewer real bad. (Knowing the mistake and not rectifying)
– Dawny33
Dec 9 '15 at 7:36
Well they told me to send my code out for review a week ago, and I don't want them to think I'm not following orders.
– user44796
Dec 9 '15 at 7:37
3
You could have informed this to your mentor before, when they asked you for a code review. It's not late now, but don't expect a very positive response now. A week is a lot of wasted time at production.
– Dawny33
Dec 9 '15 at 7:40
2
This question may be a better fit for Software Engineering
– Jan Doggen
Dec 9 '15 at 8:07
5
you have had a week and not cleaned it up?
– Kilisi
Dec 9 '15 at 8:23
1
1
When you know that your code is below mediocre quality, then why do you want to send it for the review? Trust me, this would piss off the reviewer real bad. (Knowing the mistake and not rectifying)
– Dawny33
Dec 9 '15 at 7:36
When you know that your code is below mediocre quality, then why do you want to send it for the review? Trust me, this would piss off the reviewer real bad. (Knowing the mistake and not rectifying)
– Dawny33
Dec 9 '15 at 7:36
Well they told me to send my code out for review a week ago, and I don't want them to think I'm not following orders.
– user44796
Dec 9 '15 at 7:37
Well they told me to send my code out for review a week ago, and I don't want them to think I'm not following orders.
– user44796
Dec 9 '15 at 7:37
3
3
You could have informed this to your mentor before, when they asked you for a code review. It's not late now, but don't expect a very positive response now. A week is a lot of wasted time at production.
– Dawny33
Dec 9 '15 at 7:40
You could have informed this to your mentor before, when they asked you for a code review. It's not late now, but don't expect a very positive response now. A week is a lot of wasted time at production.
– Dawny33
Dec 9 '15 at 7:40
2
2
This question may be a better fit for Software Engineering
– Jan Doggen
Dec 9 '15 at 8:07
This question may be a better fit for Software Engineering
– Jan Doggen
Dec 9 '15 at 8:07
5
5
you have had a week and not cleaned it up?
– Kilisi
Dec 9 '15 at 8:23
you have had a week and not cleaned it up?
– Kilisi
Dec 9 '15 at 8:23
 |Â
show 3 more comments
3 Answers
3
active
oldest
votes
up vote
8
down vote
accepted
When it's done. Or, more accurately, when it's good enough. You shall not be too picky, and some details will be forgiven to an intern, but hard-coded values? debugs? Argh, those are a no-go.
OTOH, if you're late, ask for help. I know it's one of the toughest things to do, but it's part of your job. If you did your "homework" before and can show people the progress you've mede, usually, they'll be likely to help you for the final part(a little bit like on stack overflow).
answered Dec 9 '15 at 7:44
gazzz0x2z
5,93621634
2
a lot of logging statements and random stuff that should never see the light of day in production level code! I wouldn't forgive even an intern, in this case! And there's hard-coding too.
– Dawny33
Dec 9 '15 at 7:46
rephrased to take your excellent comment in account.
– gazzz0x2z
Dec 9 '15 at 7:54
Please don't answer off-topic questions
– DJClayworth
Dec 9 '15 at 17:56
He might ask you for a code review to make sure you are on the right track. You should ask the purpose of this code review. He might not be expecting you to be close to finishing it.
– dyesdyes
Dec 10 '15 at 4:28
suggest improvements |Â
up vote
4
down vote
As you say you are already late, first thing you'd want to do is inform your mentor that you are stuck and needs help.
Do this before going to the code review, as all those bugs and backlog you have mentioned are intolerable during code reviews.
Yes, you would need to hear a word or two from your mentor as you are late by a week, and still have those irritating backlogs.
But still, come out clean. Confess and ask help. You are an intern, and they'd understand and would help you with that.
answered Dec 9 '15 at 8:25
Dawny33
12.2k34563
1
Part of the code review is for others to review your code and you ask any questions if you're stuck. I think the OP should go with the code review with the understanding it is not a working solution. For example, OP can walk through the code and say, "I'm stuck at point X because of Y. I understand A, B, C but cannot figure out Y."
– Dan
Dec 9 '15 at 20:47
@Dan Code reviews demand, if not perfection, but some good standards when it comes to code. The OP's code is sub-optimal, and can't be considered worthy enough for the review. So, he must have a talk with the mentor before the review IMO :)
– Dawny33
Dec 10 '15 at 3:04
suggest improvements |Â
up vote
3
down vote
Don't listen to Dawny33, you're intern you're expected to make mistake(and this is why code review exist), the best thing you can do is sit next to the reviewer and explain your code, tell him that you successfully complete the task given, but found out that the performance is bad maybe tell him/her that you already try this and that but the performance still bad, then ask is there's another way to improve performance or how to do it the right way.
I doubt the reviewer will get angry, it's not like you do this 10 times, this is your first time, the best thing you can do now is to complete your task, listen to your reviewer/senior, and try to learn from your mistake if it happen and try not to make same mistake again.
edit: honestly I'm not bothered by logging when reviewing someone's code, I usually just told them to remove it before pushing it to development, but if you're that afraid just remove them.
answered Dec 9 '15 at 8:46
kirie
31418
+1: If you use a proper logging framework, you can usually set a logging level filter to filter out Debug logging so it's not a code smell. No logging is a code smell, imho.
– toadflakz
Dec 9 '15 at 9:22
1
Don't listen to Dawny33's comments or the answer? :) Both are related. You can't just walk into your mentor just like that after stalling one week of production time code activity. You need to confess and ask for mentorship. (Yeah, I agree with your answer)
– Dawny33
Dec 9 '15 at 9:50
1
While an intern is expected to make mistakes, at least my interns are not expected to make mistakes and not correct them even if they know about them. It's only an honest mistake if you don't know better. If you do know better, it's unprofessional, even for an intern.
– nvoigt
Dec 9 '15 at 10:16
@nvoigt I don't know, putting logging in the code and producing slow performance code doesn't sound like mistake to me.
– kirie
Dec 9 '15 at 10:35
1
Producing slow performance is not bad. But code review is for code that is supposedly good by the standards of the coder. If the code has problems, then you should ask for help for that specific problem, not put it under general code review in the hopes that the reviewer will eventually fix that problem as well.
– nvoigt
Dec 9 '15 at 10:57
 |Â
show 1 more comment
3 Answers
3
active
oldest
votes
3 Answers
3
active
oldest
votes
active
oldest
votes
active
oldest
votes
up vote
8
down vote
accepted
When it's done. Or, more accurately, when it's good enough. You shall not be too picky, and some details will be forgiven to an intern, but hard-coded values? debugs? Argh, those are a no-go.
OTOH, if you're late, ask for help. I know it's one of the toughest things to do, but it's part of your job. If you did your "homework" before and can show people the progress you've mede, usually, they'll be likely to help you for the final part(a little bit like on stack overflow).
answered Dec 9 '15 at 7:44
gazzz0x2z
5,93621634
2
a lot of logging statements and random stuff that should never see the light of day in production level code! I wouldn't forgive even an intern, in this case! And there's hard-coding too.
– Dawny33
Dec 9 '15 at 7:46
rephrased to take your excellent comment in account.
– gazzz0x2z
Dec 9 '15 at 7:54
Please don't answer off-topic questions
– DJClayworth
Dec 9 '15 at 17:56
He might ask you for a code review to make sure you are on the right track. You should ask the purpose of this code review. He might not be expecting you to be close to finishing it.
– dyesdyes
Dec 10 '15 at 4:28
suggest improvements |Â
up vote
8
down vote
accepted
When it's done. Or, more accurately, when it's good enough. You shall not be too picky, and some details will be forgiven to an intern, but hard-coded values? debugs? Argh, those are a no-go.
OTOH, if you're late, ask for help. I know it's one of the toughest things to do, but it's part of your job. If you did your "homework" before and can show people the progress you've mede, usually, they'll be likely to help you for the final part(a little bit like on stack overflow).
answered Dec 9 '15 at 7:44
gazzz0x2z
5,93621634
2
a lot of logging statements and random stuff that should never see the light of day in production level code! I wouldn't forgive even an intern, in this case! And there's hard-coding too.
– Dawny33
Dec 9 '15 at 7:46
rephrased to take your excellent comment in account.
– gazzz0x2z
Dec 9 '15 at 7:54
Please don't answer off-topic questions
– DJClayworth
Dec 9 '15 at 17:56
He might ask you for a code review to make sure you are on the right track. You should ask the purpose of this code review. He might not be expecting you to be close to finishing it.
– dyesdyes
Dec 10 '15 at 4:28
suggest improvements |Â
up vote
8
down vote
accepted
up vote
8
down vote
accepted
When it's done. Or, more accurately, when it's good enough. You shall not be too picky, and some details will be forgiven to an intern, but hard-coded values? debugs? Argh, those are a no-go.
OTOH, if you're late, ask for help. I know it's one of the toughest things to do, but it's part of your job. If you did your "homework" before and can show people the progress you've mede, usually, they'll be likely to help you for the final part(a little bit like on stack overflow).
answered Dec 9 '15 at 7:44
gazzz0x2z
5,93621634
When it's done. Or, more accurately, when it's good enough. You shall not be too picky, and some details will be forgiven to an intern, but hard-coded values? debugs? Argh, those are a no-go.
OTOH, if you're late, ask for help. I know it's one of the toughest things to do, but it's part of your job. If you did your "homework" before and can show people the progress you've mede, usually, they'll be likely to help you for the final part(a little bit like on stack overflow).
answered Dec 9 '15 at 7:44
gazzz0x2z
5,93621634
edited Dec 9 '15 at 7:53
answered Dec 9 '15 at 7:44
gazzz0x2z
5,93621634
answered Dec 9 '15 at 7:44
gazzz0x2z
5,93621634
answered Dec 9 '15 at 7:44
gazzz0x2z
5,93621634
5,93621634
2
a lot of logging statements and random stuff that should never see the light of day in production level code! I wouldn't forgive even an intern, in this case! And there's hard-coding too.
– Dawny33
Dec 9 '15 at 7:46
rephrased to take your excellent comment in account.
– gazzz0x2z
Dec 9 '15 at 7:54
Please don't answer off-topic questions
– DJClayworth
Dec 9 '15 at 17:56
He might ask you for a code review to make sure you are on the right track. You should ask the purpose of this code review. He might not be expecting you to be close to finishing it.
– dyesdyes
Dec 10 '15 at 4:28
suggest improvements |Â
2
a lot of logging statements and random stuff that should never see the light of day in production level code! I wouldn't forgive even an intern, in this case! And there's hard-coding too.
– Dawny33
Dec 9 '15 at 7:46
rephrased to take your excellent comment in account.
– gazzz0x2z
Dec 9 '15 at 7:54
Please don't answer off-topic questions
– DJClayworth
Dec 9 '15 at 17:56
He might ask you for a code review to make sure you are on the right track. You should ask the purpose of this code review. He might not be expecting you to be close to finishing it.
– dyesdyes
Dec 10 '15 at 4:28
2
2
a lot of logging statements and random stuff that should never see the light of day in production level code! I wouldn't forgive even an intern, in this case! And there's hard-coding too.
– Dawny33
Dec 9 '15 at 7:46
a lot of logging statements and random stuff that should never see the light of day in production level code! I wouldn't forgive even an intern, in this case! And there's hard-coding too.
– Dawny33
Dec 9 '15 at 7:46
rephrased to take your excellent comment in account.
– gazzz0x2z
Dec 9 '15 at 7:54
rephrased to take your excellent comment in account.
– gazzz0x2z
Dec 9 '15 at 7:54
Please don't answer off-topic questions
– DJClayworth
Dec 9 '15 at 17:56
Please don't answer off-topic questions
– DJClayworth
Dec 9 '15 at 17:56
He might ask you for a code review to make sure you are on the right track. You should ask the purpose of this code review. He might not be expecting you to be close to finishing it.
– dyesdyes
Dec 10 '15 at 4:28
He might ask you for a code review to make sure you are on the right track. You should ask the purpose of this code review. He might not be expecting you to be close to finishing it.
– dyesdyes
Dec 10 '15 at 4:28
suggest improvements |Â
up vote
4
down vote
As you say you are already late, first thing you'd want to do is inform your mentor that you are stuck and needs help.
Do this before going to the code review, as all those bugs and backlog you have mentioned are intolerable during code reviews.
Yes, you would need to hear a word or two from your mentor as you are late by a week, and still have those irritating backlogs.
But still, come out clean. Confess and ask help. You are an intern, and they'd understand and would help you with that.
answered Dec 9 '15 at 8:25
Dawny33
12.2k34563
1
Part of the code review is for others to review your code and you ask any questions if you're stuck. I think the OP should go with the code review with the understanding it is not a working solution. For example, OP can walk through the code and say, "I'm stuck at point X because of Y. I understand A, B, C but cannot figure out Y."
– Dan
Dec 9 '15 at 20:47
@Dan Code reviews demand, if not perfection, but some good standards when it comes to code. The OP's code is sub-optimal, and can't be considered worthy enough for the review. So, he must have a talk with the mentor before the review IMO :)
– Dawny33
Dec 10 '15 at 3:04
suggest improvements |Â
up vote
4
down vote
As you say you are already late, first thing you'd want to do is inform your mentor that you are stuck and needs help.
Do this before going to the code review, as all those bugs and backlog you have mentioned are intolerable during code reviews.
Yes, you would need to hear a word or two from your mentor as you are late by a week, and still have those irritating backlogs.
But still, come out clean. Confess and ask help. You are an intern, and they'd understand and would help you with that.
answered Dec 9 '15 at 8:25
Dawny33
12.2k34563
1
Part of the code review is for others to review your code and you ask any questions if you're stuck. I think the OP should go with the code review with the understanding it is not a working solution. For example, OP can walk through the code and say, "I'm stuck at point X because of Y. I understand A, B, C but cannot figure out Y."
– Dan
Dec 9 '15 at 20:47
@Dan Code reviews demand, if not perfection, but some good standards when it comes to code. The OP's code is sub-optimal, and can't be considered worthy enough for the review. So, he must have a talk with the mentor before the review IMO :)
– Dawny33
Dec 10 '15 at 3:04
suggest improvements |Â
up vote
4
down vote
up vote
4
down vote
As you say you are already late, first thing you'd want to do is inform your mentor that you are stuck and needs help.
Do this before going to the code review, as all those bugs and backlog you have mentioned are intolerable during code reviews.
Yes, you would need to hear a word or two from your mentor as you are late by a week, and still have those irritating backlogs.
But still, come out clean. Confess and ask help. You are an intern, and they'd understand and would help you with that.
answered Dec 9 '15 at 8:25
Dawny33
12.2k34563
As you say you are already late, first thing you'd want to do is inform your mentor that you are stuck and needs help.
Do this before going to the code review, as all those bugs and backlog you have mentioned are intolerable during code reviews.
Yes, you would need to hear a word or two from your mentor as you are late by a week, and still have those irritating backlogs.
But still, come out clean. Confess and ask help. You are an intern, and they'd understand and would help you with that.
answered Dec 9 '15 at 8:25
Dawny33
12.2k34563
answered Dec 9 '15 at 8:25
Dawny33
12.2k34563
answered Dec 9 '15 at 8:25
Dawny33
12.2k34563
answered Dec 9 '15 at 8:25
Dawny33
12.2k34563
12.2k34563
1
Part of the code review is for others to review your code and you ask any questions if you're stuck. I think the OP should go with the code review with the understanding it is not a working solution. For example, OP can walk through the code and say, "I'm stuck at point X because of Y. I understand A, B, C but cannot figure out Y."
– Dan
Dec 9 '15 at 20:47
@Dan Code reviews demand, if not perfection, but some good standards when it comes to code. The OP's code is sub-optimal, and can't be considered worthy enough for the review. So, he must have a talk with the mentor before the review IMO :)
– Dawny33
Dec 10 '15 at 3:04
suggest improvements |Â
1
Part of the code review is for others to review your code and you ask any questions if you're stuck. I think the OP should go with the code review with the understanding it is not a working solution. For example, OP can walk through the code and say, "I'm stuck at point X because of Y. I understand A, B, C but cannot figure out Y."
– Dan
Dec 9 '15 at 20:47
@Dan Code reviews demand, if not perfection, but some good standards when it comes to code. The OP's code is sub-optimal, and can't be considered worthy enough for the review. So, he must have a talk with the mentor before the review IMO :)
– Dawny33
Dec 10 '15 at 3:04
1
1
Part of the code review is for others to review your code and you ask any questions if you're stuck. I think the OP should go with the code review with the understanding it is not a working solution. For example, OP can walk through the code and say, "I'm stuck at point X because of Y. I understand A, B, C but cannot figure out Y."
– Dan
Dec 9 '15 at 20:47
Part of the code review is for others to review your code and you ask any questions if you're stuck. I think the OP should go with the code review with the understanding it is not a working solution. For example, OP can walk through the code and say, "I'm stuck at point X because of Y. I understand A, B, C but cannot figure out Y."
– Dan
Dec 9 '15 at 20:47
@Dan Code reviews demand, if not perfection, but some good standards when it comes to code. The OP's code is sub-optimal, and can't be considered worthy enough for the review. So, he must have a talk with the mentor before the review IMO :)
– Dawny33
Dec 10 '15 at 3:04
@Dan Code reviews demand, if not perfection, but some good standards when it comes to code. The OP's code is sub-optimal, and can't be considered worthy enough for the review. So, he must have a talk with the mentor before the review IMO :)
– Dawny33
Dec 10 '15 at 3:04
suggest improvements |Â
up vote
3
down vote
Don't listen to Dawny33, you're intern you're expected to make mistake(and this is why code review exist), the best thing you can do is sit next to the reviewer and explain your code, tell him that you successfully complete the task given, but found out that the performance is bad maybe tell him/her that you already try this and that but the performance still bad, then ask is there's another way to improve performance or how to do it the right way.
I doubt the reviewer will get angry, it's not like you do this 10 times, this is your first time, the best thing you can do now is to complete your task, listen to your reviewer/senior, and try to learn from your mistake if it happen and try not to make same mistake again.
edit: honestly I'm not bothered by logging when reviewing someone's code, I usually just told them to remove it before pushing it to development, but if you're that afraid just remove them.
answered Dec 9 '15 at 8:46
kirie
31418
+1: If you use a proper logging framework, you can usually set a logging level filter to filter out Debug logging so it's not a code smell. No logging is a code smell, imho.
– toadflakz
Dec 9 '15 at 9:22
1
Don't listen to Dawny33's comments or the answer? :) Both are related. You can't just walk into your mentor just like that after stalling one week of production time code activity. You need to confess and ask for mentorship. (Yeah, I agree with your answer)
– Dawny33
Dec 9 '15 at 9:50
1
While an intern is expected to make mistakes, at least my interns are not expected to make mistakes and not correct them even if they know about them. It's only an honest mistake if you don't know better. If you do know better, it's unprofessional, even for an intern.
– nvoigt
Dec 9 '15 at 10:16
@nvoigt I don't know, putting logging in the code and producing slow performance code doesn't sound like mistake to me.
– kirie
Dec 9 '15 at 10:35
1
Producing slow performance is not bad. But code review is for code that is supposedly good by the standards of the coder. If the code has problems, then you should ask for help for that specific problem, not put it under general code review in the hopes that the reviewer will eventually fix that problem as well.
– nvoigt
Dec 9 '15 at 10:57
 |Â
show 1 more comment
up vote
3
down vote
Don't listen to Dawny33, you're intern you're expected to make mistake(and this is why code review exist), the best thing you can do is sit next to the reviewer and explain your code, tell him that you successfully complete the task given, but found out that the performance is bad maybe tell him/her that you already try this and that but the performance still bad, then ask is there's another way to improve performance or how to do it the right way.
I doubt the reviewer will get angry, it's not like you do this 10 times, this is your first time, the best thing you can do now is to complete your task, listen to your reviewer/senior, and try to learn from your mistake if it happen and try not to make same mistake again.
edit: honestly I'm not bothered by logging when reviewing someone's code, I usually just told them to remove it before pushing it to development, but if you're that afraid just remove them.
answered Dec 9 '15 at 8:46
kirie
31418
+1: If you use a proper logging framework, you can usually set a logging level filter to filter out Debug logging so it's not a code smell. No logging is a code smell, imho.
– toadflakz
Dec 9 '15 at 9:22
1
Don't listen to Dawny33's comments or the answer? :) Both are related. You can't just walk into your mentor just like that after stalling one week of production time code activity. You need to confess and ask for mentorship. (Yeah, I agree with your answer)
– Dawny33
Dec 9 '15 at 9:50
1
While an intern is expected to make mistakes, at least my interns are not expected to make mistakes and not correct them even if they know about them. It's only an honest mistake if you don't know better. If you do know better, it's unprofessional, even for an intern.
– nvoigt
Dec 9 '15 at 10:16
@nvoigt I don't know, putting logging in the code and producing slow performance code doesn't sound like mistake to me.
– kirie
Dec 9 '15 at 10:35
1
Producing slow performance is not bad. But code review is for code that is supposedly good by the standards of the coder. If the code has problems, then you should ask for help for that specific problem, not put it under general code review in the hopes that the reviewer will eventually fix that problem as well.
– nvoigt
Dec 9 '15 at 10:57
 |Â
show 1 more comment
up vote
3
down vote
up vote
3
down vote
Don't listen to Dawny33, you're intern you're expected to make mistake(and this is why code review exist), the best thing you can do is sit next to the reviewer and explain your code, tell him that you successfully complete the task given, but found out that the performance is bad maybe tell him/her that you already try this and that but the performance still bad, then ask is there's another way to improve performance or how to do it the right way.
I doubt the reviewer will get angry, it's not like you do this 10 times, this is your first time, the best thing you can do now is to complete your task, listen to your reviewer/senior, and try to learn from your mistake if it happen and try not to make same mistake again.
edit: honestly I'm not bothered by logging when reviewing someone's code, I usually just told them to remove it before pushing it to development, but if you're that afraid just remove them.
answered Dec 9 '15 at 8:46
kirie
31418
Don't listen to Dawny33, you're intern you're expected to make mistake(and this is why code review exist), the best thing you can do is sit next to the reviewer and explain your code, tell him that you successfully complete the task given, but found out that the performance is bad maybe tell him/her that you already try this and that but the performance still bad, then ask is there's another way to improve performance or how to do it the right way.
I doubt the reviewer will get angry, it's not like you do this 10 times, this is your first time, the best thing you can do now is to complete your task, listen to your reviewer/senior, and try to learn from your mistake if it happen and try not to make same mistake again.
edit: honestly I'm not bothered by logging when reviewing someone's code, I usually just told them to remove it before pushing it to development, but if you're that afraid just remove them.
answered Dec 9 '15 at 8:46
kirie
31418
answered Dec 9 '15 at 8:46
kirie
31418
answered Dec 9 '15 at 8:46
kirie
31418
answered Dec 9 '15 at 8:46
kirie
31418
31418
+1: If you use a proper logging framework, you can usually set a logging level filter to filter out Debug logging so it's not a code smell. No logging is a code smell, imho.
– toadflakz
Dec 9 '15 at 9:22
1
Don't listen to Dawny33's comments or the answer? :) Both are related. You can't just walk into your mentor just like that after stalling one week of production time code activity. You need to confess and ask for mentorship. (Yeah, I agree with your answer)
– Dawny33
Dec 9 '15 at 9:50
1
While an intern is expected to make mistakes, at least my interns are not expected to make mistakes and not correct them even if they know about them. It's only an honest mistake if you don't know better. If you do know better, it's unprofessional, even for an intern.
– nvoigt
Dec 9 '15 at 10:16
@nvoigt I don't know, putting logging in the code and producing slow performance code doesn't sound like mistake to me.
– kirie
Dec 9 '15 at 10:35
1
Producing slow performance is not bad. But code review is for code that is supposedly good by the standards of the coder. If the code has problems, then you should ask for help for that specific problem, not put it under general code review in the hopes that the reviewer will eventually fix that problem as well.
– nvoigt
Dec 9 '15 at 10:57
 |Â
show 1 more comment
+1: If you use a proper logging framework, you can usually set a logging level filter to filter out Debug logging so it's not a code smell. No logging is a code smell, imho.
– toadflakz
Dec 9 '15 at 9:22
1
Don't listen to Dawny33's comments or the answer? :) Both are related. You can't just walk into your mentor just like that after stalling one week of production time code activity. You need to confess and ask for mentorship. (Yeah, I agree with your answer)
– Dawny33
Dec 9 '15 at 9:50
1
While an intern is expected to make mistakes, at least my interns are not expected to make mistakes and not correct them even if they know about them. It's only an honest mistake if you don't know better. If you do know better, it's unprofessional, even for an intern.
– nvoigt
Dec 9 '15 at 10:16
@nvoigt I don't know, putting logging in the code and producing slow performance code doesn't sound like mistake to me.
– kirie
Dec 9 '15 at 10:35
1
Producing slow performance is not bad. But code review is for code that is supposedly good by the standards of the coder. If the code has problems, then you should ask for help for that specific problem, not put it under general code review in the hopes that the reviewer will eventually fix that problem as well.
– nvoigt
Dec 9 '15 at 10:57
+1: If you use a proper logging framework, you can usually set a logging level filter to filter out Debug logging so it's not a code smell. No logging is a code smell, imho.
– toadflakz
Dec 9 '15 at 9:22
+1: If you use a proper logging framework, you can usually set a logging level filter to filter out Debug logging so it's not a code smell. No logging is a code smell, imho.
– toadflakz
Dec 9 '15 at 9:22
1
1
Don't listen to Dawny33's comments or the answer? :) Both are related. You can't just walk into your mentor just like that after stalling one week of production time code activity. You need to confess and ask for mentorship. (Yeah, I agree with your answer)
– Dawny33
Dec 9 '15 at 9:50
Don't listen to Dawny33's comments or the answer? :) Both are related. You can't just walk into your mentor just like that after stalling one week of production time code activity. You need to confess and ask for mentorship. (Yeah, I agree with your answer)
– Dawny33
Dec 9 '15 at 9:50
1
1
While an intern is expected to make mistakes, at least my interns are not expected to make mistakes and not correct them even if they know about them. It's only an honest mistake if you don't know better. If you do know better, it's unprofessional, even for an intern.
– nvoigt
Dec 9 '15 at 10:16
While an intern is expected to make mistakes, at least my interns are not expected to make mistakes and not correct them even if they know about them. It's only an honest mistake if you don't know better. If you do know better, it's unprofessional, even for an intern.
– nvoigt
Dec 9 '15 at 10:16
@nvoigt I don't know, putting logging in the code and producing slow performance code doesn't sound like mistake to me.
– kirie
Dec 9 '15 at 10:35
@nvoigt I don't know, putting logging in the code and producing slow performance code doesn't sound like mistake to me.
– kirie
Dec 9 '15 at 10:35
1
1
Producing slow performance is not bad. But code review is for code that is supposedly good by the standards of the coder. If the code has problems, then you should ask for help for that specific problem, not put it under general code review in the hopes that the reviewer will eventually fix that problem as well.
– nvoigt
Dec 9 '15 at 10:57
Producing slow performance is not bad. But code review is for code that is supposedly good by the standards of the coder. If the code has problems, then you should ask for help for that specific problem, not put it under general code review in the hopes that the reviewer will eventually fix that problem as well.
– nvoigt
Dec 9 '15 at 10:57
 |Â
show 1 more comment
1
When you know that your code is below mediocre quality, then why do you want to send it for the review? Trust me, this would piss off the reviewer real bad. (Knowing the mistake and not rectifying)
– Dawny33
Dec 9 '15 at 7:36
Well they told me to send my code out for review a week ago, and I don't want them to think I'm not following orders.
– user44796
Dec 9 '15 at 7:37
3
You could have informed this to your mentor before, when they asked you for a code review. It's not late now, but don't expect a very positive response now. A week is a lot of wasted time at production.
– Dawny33
Dec 9 '15 at 7:40
2
This question may be a better fit for Software Engineering
– Jan Doggen
Dec 9 '15 at 8:07
5
you have had a week and not cleaned it up?
– Kilisi
Dec 9 '15 at 8:23