Walker_Nav_Menu: Items not nested correctly

The name of the pictureThe name of the pictureThe name of the pictureClash Royale CLAN TAG#URR8PPP





.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty margin-bottom:0;







up vote
2
down vote

favorite












I want to add "anchor" tag adjacent to every "list item" that has children.



this is my Walker_Nav_Menu class:



class Menu_Walker extends Walker_Nav_Menu {

function start_el( &$output, $item, $depth = 0, $args = array(), $id = 0 ) 

 $ident = str_repeat( "t", $depth );

 if ( $args->walker->has_children ) 

 $classes = 'menu-item-has-children menu-item menu-item-' . $item->ID;

 // actual link
 $output .= "$ident<li class="$classes"><a href="$item->url">$item->title</a></li>n";

 // added tag after
 $output .= "<a class="added" href="#">txt</a>";

 else 

 $classes = 'menu-item menu-item-' . $item->ID;

 // actual link
 $output .= "$ident<li class="$classes"><a href="$item->url">$item->title</a></li>n";



This is the structure of the menu in WordPress:



enter image description here



But the output is not nested correctly as you can see in image below:



enter image description here



Please help me fix this problem






menus







share|improve this question









New contributor




Rozo is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.



















  • Of course they’re not nested correctly. You close li tag in your start_el, so how could they be correct ;)
    – Krzysiek Dróżdż
    2 hours ago






  • 1




    @Krzysiek Dróżdż omg you're correct, I was trying to solve this problem for the last 2 hours, removing the li closing tag solved it thank you so much.
    – Rozo
    2 hours ago

















up vote
2
down vote

favorite












I want to add "anchor" tag adjacent to every "list item" that has children.



this is my Walker_Nav_Menu class:



class Menu_Walker extends Walker_Nav_Menu {

function start_el( &$output, $item, $depth = 0, $args = array(), $id = 0 ) 

 $ident = str_repeat( "t", $depth );

 if ( $args->walker->has_children ) 

 $classes = 'menu-item-has-children menu-item menu-item-' . $item->ID;

 // actual link
 $output .= "$ident<li class="$classes"><a href="$item->url">$item->title</a></li>n";

 // added tag after
 $output .= "<a class="added" href="#">txt</a>";

 else 

 $classes = 'menu-item menu-item-' . $item->ID;

 // actual link
 $output .= "$ident<li class="$classes"><a href="$item->url">$item->title</a></li>n";



This is the structure of the menu in WordPress:



enter image description here



But the output is not nested correctly as you can see in image below:



enter image description here



Please help me fix this problem






menus







share|improve this question









New contributor




Rozo is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.



















  • Of course they’re not nested correctly. You close li tag in your start_el, so how could they be correct ;)
    – Krzysiek Dróżdż
    2 hours ago






  • 1




    @Krzysiek Dróżdż omg you're correct, I was trying to solve this problem for the last 2 hours, removing the li closing tag solved it thank you so much.
    – Rozo
    2 hours ago













up vote
2
down vote

favorite









up vote
2
down vote

favorite











I want to add "anchor" tag adjacent to every "list item" that has children.



this is my Walker_Nav_Menu class:



class Menu_Walker extends Walker_Nav_Menu {

function start_el( &$output, $item, $depth = 0, $args = array(), $id = 0 ) 

 $ident = str_repeat( "t", $depth );

 if ( $args->walker->has_children ) 

 $classes = 'menu-item-has-children menu-item menu-item-' . $item->ID;

 // actual link
 $output .= "$ident<li class="$classes"><a href="$item->url">$item->title</a></li>n";

 // added tag after
 $output .= "<a class="added" href="#">txt</a>";

 else 

 $classes = 'menu-item menu-item-' . $item->ID;

 // actual link
 $output .= "$ident<li class="$classes"><a href="$item->url">$item->title</a></li>n";



This is the structure of the menu in WordPress:



enter image description here



But the output is not nested correctly as you can see in image below:



enter image description here



Please help me fix this problem






menus







share|improve this question









New contributor




Rozo is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.











I want to add "anchor" tag adjacent to every "list item" that has children.



this is my Walker_Nav_Menu class:



class Menu_Walker extends Walker_Nav_Menu {

function start_el( &$output, $item, $depth = 0, $args = array(), $id = 0 ) 

 $ident = str_repeat( "t", $depth );

 if ( $args->walker->has_children ) 

 $classes = 'menu-item-has-children menu-item menu-item-' . $item->ID;

 // actual link
 $output .= "$ident<li class="$classes"><a href="$item->url">$item->title</a></li>n";

 // added tag after
 $output .= "<a class="added" href="#">txt</a>";

 else 

 $classes = 'menu-item menu-item-' . $item->ID;

 // actual link
 $output .= "$ident<li class="$classes"><a href="$item->url">$item->title</a></li>n";



This is the structure of the menu in WordPress:



enter image description here



But the output is not nested correctly as you can see in image below:



enter image description here



Please help me fix this problem






menus




menus






share|improve this question









New contributor




Rozo is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.











share|improve this question









New contributor




Rozo is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.









share|improve this question




share|improve this question








edited 1 hour ago









Krzysiek Dróżdż

11.7k42637




11.7k42637






New contributor




Rozo is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.









asked 2 hours ago









Rozo

132




132




New contributor




Rozo is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.





New contributor





Rozo is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.






Rozo is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.











  • Of course they’re not nested correctly. You close li tag in your start_el, so how could they be correct ;)
    – Krzysiek Dróżdż
    2 hours ago






  • 1




    @Krzysiek Dróżdż omg you're correct, I was trying to solve this problem for the last 2 hours, removing the li closing tag solved it thank you so much.
    – Rozo
    2 hours ago

















  • Of course they’re not nested correctly. You close li tag in your start_el, so how could they be correct ;)
    – Krzysiek Dróżdż
    2 hours ago






  • 1




    @Krzysiek Dróżdż omg you're correct, I was trying to solve this problem for the last 2 hours, removing the li closing tag solved it thank you so much.
    – Rozo
    2 hours ago
















Of course they’re not nested correctly. You close li tag in your start_el, so how could they be correct ;)
– Krzysiek Dróżdż
2 hours ago




Of course they’re not nested correctly. You close li tag in your start_el, so how could they be correct ;)
– Krzysiek Dróżdż
2 hours ago




1




1




@Krzysiek Dróżdż omg you're correct, I was trying to solve this problem for the last 2 hours, removing the li closing tag solved it thank you so much.
– Rozo
2 hours ago





@Krzysiek Dróżdż omg you're correct, I was trying to solve this problem for the last 2 hours, removing the li closing tag solved it thank you so much.
– Rozo
2 hours ago











1 Answer
1






active

oldest

votes

















up vote
2
down vote



accepted










You have this problem, because of your code ;) 



function start_el( &$output, $item, $depth = 0, $args = array(), $id = 0 ) 

 $ident = str_repeat( "t", $depth );

 if ( $args->walker->has_children ) 

 $classes = 'menu-item-has-children menu-item menu-item-' . $item->ID;

 // actual link
 // you SHOULDN'T close the li tag in here
 $output .= "$ident<li class="$classes"><a href="$item->url">$item->title</a></li>n";

 // added tag after
 $output .= "<a class="added" href="#">txt</a>";

 else 

 $classes = 'menu-item menu-item-' . $item->ID;

 // actual link
 // you SHOULDN'T close the li tag in here
 $output .= "$ident<li class="$classes"><a href="$item->url">$item->title</a></li>n";



In your start_el you close the li tag, so children can't be printed inside of it...






share|improve this answer




















    Your Answer







    StackExchange.ready(function()
    var channelOptions =
    tags: "".split(" "),
    id: "110"
    ;
    initTagRenderer("".split(" "), "".split(" "), channelOptions);

    StackExchange.using("externalEditor", function()
    // Have to fire editor after snippets, if snippets enabled
    if (StackExchange.settings.snippets.snippetsEnabled)
    StackExchange.using("snippets", function()
    createEditor();
    );

    else
    createEditor();

    );

    function createEditor()
    StackExchange.prepareEditor(
    heartbeatType: 'answer',
    convertImagesToLinks: false,
    noModals: false,
    showLowRepImageUploadWarning: true,
    reputationToPostImages: null,
    bindNavPrevention: true,
    postfix: "",
    onDemand: true,
    discardSelector: ".discard-answer"
    ,immediatelyShowMarkdownHelp:true
    );



    );






    Rozo is a new contributor. Be nice, and check out our Code of Conduct.









     

    draft saved


    draft discarded


















    StackExchange.ready(
    function ()
    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fwordpress.stackexchange.com%2fquestions%2f316299%2fwalker-nav-menu-items-not-nested-correctly%23new-answer', 'question_page');

    );

    Post as a guest

















    1 Answer
    1






    active

    oldest

    votes








    1 Answer
    1






    active

    oldest

    votes









    active

    oldest

    votes






    active

    oldest

    votes








    up vote
    2
    down vote



    accepted










    You have this problem, because of your code ;) 



    function start_el( &$output, $item, $depth = 0, $args = array(), $id = 0 ) 

     $ident = str_repeat( "t", $depth );

     if ( $args->walker->has_children ) 

     $classes = 'menu-item-has-children menu-item menu-item-' . $item->ID;

     // actual link
     // you SHOULDN'T close the li tag in here
     $output .= "$ident<li class="$classes"><a href="$item->url">$item->title</a></li>n";

     // added tag after
     $output .= "<a class="added" href="#">txt</a>";

     else 

     $classes = 'menu-item menu-item-' . $item->ID;

     // actual link
     // you SHOULDN'T close the li tag in here
     $output .= "$ident<li class="$classes"><a href="$item->url">$item->title</a></li>n";



    In your start_el you close the li tag, so children can't be printed inside of it...






    share|improve this answer
























      up vote
      2
      down vote



      accepted










      You have this problem, because of your code ;) 



      function start_el( &$output, $item, $depth = 0, $args = array(), $id = 0 ) 

       $ident = str_repeat( "t", $depth );

       if ( $args->walker->has_children ) 

       $classes = 'menu-item-has-children menu-item menu-item-' . $item->ID;

       // actual link
       // you SHOULDN'T close the li tag in here
       $output .= "$ident<li class="$classes"><a href="$item->url">$item->title</a></li>n";

       // added tag after
       $output .= "<a class="added" href="#">txt</a>";

       else 

       $classes = 'menu-item menu-item-' . $item->ID;

       // actual link
       // you SHOULDN'T close the li tag in here
       $output .= "$ident<li class="$classes"><a href="$item->url">$item->title</a></li>n";



      In your start_el you close the li tag, so children can't be printed inside of it...






      share|improve this answer






















        up vote
        2
        down vote



        accepted







        up vote
        2
        down vote



        accepted






        You have this problem, because of your code ;) 



        function start_el( &$output, $item, $depth = 0, $args = array(), $id = 0 ) 

         $ident = str_repeat( "t", $depth );

         if ( $args->walker->has_children ) 

         $classes = 'menu-item-has-children menu-item menu-item-' . $item->ID;

         // actual link
         // you SHOULDN'T close the li tag in here
         $output .= "$ident<li class="$classes"><a href="$item->url">$item->title</a></li>n";

         // added tag after
         $output .= "<a class="added" href="#">txt</a>";

         else 

         $classes = 'menu-item menu-item-' . $item->ID;

         // actual link
         // you SHOULDN'T close the li tag in here
         $output .= "$ident<li class="$classes"><a href="$item->url">$item->title</a></li>n";



        In your start_el you close the li tag, so children can't be printed inside of it...






        share|improve this answer












        You have this problem, because of your code ;) 



        function start_el( &$output, $item, $depth = 0, $args = array(), $id = 0 ) 

         $ident = str_repeat( "t", $depth );

         if ( $args->walker->has_children ) 

         $classes = 'menu-item-has-children menu-item menu-item-' . $item->ID;

         // actual link
         // you SHOULDN'T close the li tag in here
         $output .= "$ident<li class="$classes"><a href="$item->url">$item->title</a></li>n";

         // added tag after
         $output .= "<a class="added" href="#">txt</a>";

         else 

         $classes = 'menu-item menu-item-' . $item->ID;

         // actual link
         // you SHOULDN'T close the li tag in here
         $output .= "$ident<li class="$classes"><a href="$item->url">$item->title</a></li>n";



        In your start_el you close the li tag, so children can't be printed inside of it...







        share|improve this answer












        share|improve this answer



        share|improve this answer










        answered 1 hour ago









        Krzysiek Dróżdż

        11.7k42637




        11.7k42637




















            Rozo is a new contributor. Be nice, and check out our Code of Conduct.









             

            draft saved


            draft discarded


















            Rozo is a new contributor. Be nice, and check out our Code of Conduct.












            Rozo is a new contributor. Be nice, and check out our Code of Conduct.











            Rozo is a new contributor. Be nice, and check out our Code of Conduct.













             


            draft saved


            draft discarded














            StackExchange.ready(
            function ()
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fwordpress.stackexchange.com%2fquestions%2f316299%2fwalker-nav-menu-items-not-nested-correctly%23new-answer', 'question_page');

            );

            Post as a guest
































































            Comments

            Post a Comment

            Popular posts from this blog

            What does second last employer means? [closed]

            Image
            Clash Royale CLAN TAG #URR8PPP .everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty margin-bottom:0; up vote -3 down vote favorite Say, for example I have worked in the following companies, Company A => 2010 - 2011 Company B => 2011 - 2012 Company C => 2012 - Till Date Company D => Have offer Now assume Company D is asking to submit documents from my second last employer. So from the list of companies given, which company would be qualified as second last employer? software-industry employer share | improve this question asked Aug 10 '14 at 5:16 Rajaprabhu Aravindasamy 559 1 6 13 closed as off-topic by Jim G., jmort253 ♦ Aug 11 '14 at 1:58 This question appears to be off-topic. The users who voted to close gave this specific reason: "Questions seeking advice on company-specific regulations, agreements, or policies should be directed to your manager or HR department. Questions that address...
            Read more

            List of Gilmore Girls characters

            Image
            The season three cast—(Back row): Lane, Michel, Paris, Emily, Richard, Sookie, Miss Patty, Kirk; Front row: Jess, Luke, Lorelai, Rory, Dean This is a list of characters for the comedy-drama television series Gilmore Girls . Contents 1 Main characters 1.1 Lorelai Gilmore 1.2 Rory Gilmore 1.3 Sookie St. James 1.4 Lane Kim 1.5 Michel Gerard 1.6 Luke Danes 1.7 Emily Gilmore 1.8 Richard Gilmore 1.9 Paris Geller 1.10 Dean Forester 1.11 Jess Mariano 1.12 Kirk Gleason 1.13 Jason Stiles 1.14 Logan Huntzberger 2 Major recurring characters 2.1 Christopher Hayden 2.2 Jackson Belleville 2.3 Mrs. Kim 2.4 Tristin DuGray 2.5 Max Medina 2.6 Taylor Doose 2.7 Dave Rygalski 2.8 Marty 3 Recurring characters 3.1 Stars Hollow 3.2 Chilton 3.3 Yale 3.4 Other 4 Notable guest stars 5 Unseen characters 6 Notes 7 References Main characters Actor Character Appearances Season 1 Season 2 Season 3 Season 4 Season 5 Season 6 Season 7 A Year in the Life Lauren Graham Lorelai Gilmore...
            Read more

            Confectionery

            Image
            Prepared foods made with a lot of sugar or other cabohydrates "Sweetmeat" redirects here. For the racehorse, see Sweetmeat (horse). Not to be confused with Sweetbread. This Kransekake is a traditional Scandinavian baker's confection. Confectionery is the art of making confections , which are food items that are rich in sugar and carbohydrates. Exact definitions are difficult. [1] In general, though, confectionery is divided into two broad and somewhat overlapping categories, bakers' confections and sugar confections. [2] Bakers' confectionery, also called flour confections , includes principally sweet pastries, cakes, and similar baked goods. Sugar confectionery includes candies ( sweets in British English), candied nuts, chocolates, chewing gum, bubble gum, pastillage, and other confections that are made primarily of sugar. In some cases, chocolate confections (confections made of chocolate) are treated as a separate category, as are sugar-free versions of ...
            Read more